Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: User can delete an env var by setting it to null in the manifest #1754

Open
matt-royal opened this issue Oct 6, 2022 · 1 comment
Labels

Comments

@matt-royal
Copy link
Contributor

Blockers/Dependencies

No response

Background

As a korifi user
I want to be able to delete environment variables via the manifest
So that I can use the same manifest as with cf-for-vms

Acceptance Criteria

GIVEN an application named "node" that has the environment variable test set to value (via manifest or via cf set-env)
WHEN I re-push the same app using a manifest that sets test to nil (see below)
AND I run cf env node
THEN I should see that there is no environment variable called test in the response


Here's an example manifest to clear the test env var:

applications:
  - name: node
    env:
      test: ~

Dev Notes

This will require several changes:

  • The field type for env will need to support nil values
  • The nil value will need to be passed through to AppRepo.CreateOrPatchAppEnvVars()
  • AppRepo.CreateOrPatchAppEnvVars() will need to delete any environment variable that was set to nil
@matt-royal
Copy link
Contributor Author

Based on this conversation, I think that this feature is broken in tas-for-vms also, so this isn't a priority.

@gcapizzi gcapizzi moved this to 🧊 Icebox in Korifi - Backlog Nov 29, 2022
@tcdowney tcdowney added the good first issue Good for newcomers label Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🧊 Icebox
Development

No branches or pull requests

3 participants