Support --var in cf push

[danail-branekov]

Acceptance

Acceptance

GIVEN I have pushed an app via cf push --var FOO=var, e.g.
cf push dorifi --var FOO=bar -p ~/workspace/korifi/tests/assets/dorifi

WHEN The app has started

THEN I can see the FOO env var set to bar in the application environment, e.g.
curl -k https://dorifi.apps-127-0-0-1.nip.io/env.json | jq .FOO should return bar

Dev notes

That environment variable should be made available into the <app-guid>-env secret.

FWIW, pushing the app via a manifest with env, e.g.

---
applications:
- name: dorifi
  path: /home/ccloud/workspace/korifi/tests/assets/dorifi
  env:
    FOO: bar

works as expected, i.e. the env secret contains a FOO entry and the application gets the FOO env var

[danail-branekov]

Sounds like a misunderstanding.

According to the docs and cli help

--var                        Variable key value pair for variable substitution, (e.g., name=app1); can specify multiple times
--vars-file                  Path to a variable substitution file for manifest; can specify multiple times

it sounds like --var is used to configure manifest variables (e.g. ((instances))) rather than setting whatever env vars. It seems the only way to configure custom env vars for an app during push is to use a manifest