cf push with pipenv installs dev dependencies

[benjefferies]

What version of Cloud Foundry and CF CLI are you using? (i.e. What is the output of running cf curl /v2/info && cf version?

{
   "name": "",
   "build": "",
   "support": "",
   "version": 0,
   "min_cli_version": null,
   "min_recommended_cli_version": null,
   "api_version": "2.85.0",
   "app_ssh_oauth_client": "ssh-proxy",
}
cf version 6.32.0+0191c33d9.2017-09-26

What version of the buildpack you are using?
Buildpack version 1.5.19

If you were attempting to accomplish a task, what was it you were attempting to do?

1. Use pipenv for dependency management containing both packages and dev-packages
2. cf push
   Sample Pipfile

[[source]]

verify_ssl = true
name = "pypi"
url = "https://pypi.python.org/simple"


[packages]

flask = "==0.12.2"
flask-cors = "==3.0.3"
gunicorn = "==19.7.1"
itsdangerous = "==0.24"
jsonschema = "==2.6.0"
notifications-python-client = "==4.3.1"
sqlalchemy-utils = "==0.32.14"
sqlalchemy = "==1.1.10"
"psycopg2" = "==2.7.1"
pycrypto = "==2.6.1"
python-dateutil = "==2.6.0"
pyyaml = "==3.12"
requests = "==2.17.3"
structlog = "==17.2.0"
flask-httpauth = "==3.2.3"
ras-common-utils = {git = "https://github.com/ONSdigital/ras-common-utils.git", ref = "0.0.7"}


[dev-packages]

tox = "*"
coverage = "*"
"flake8" = "*"
flask-testing = "*"

What did you expect to happen?

1. Only the packages section of the Pipfile should have been installed
2. Successfully deploy app

What was the actual behavior?

1. packages and dev-packages section of the Pipfile should have been installed.
2. Failed to cf push with the dev dependency pytest

Please confirm where necessary:

• [ x] I have included a log output
• [ x ] My log includes an error message
• [ x ] I have included steps for reproduction
  error.log

[cf-gitbot]

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/152395352

The labels on this github issue will be updated when the story is started.

[benjefferies]

Pipenv seems to be the problem here. It wasn't possible to generate a requirements.txt file without dev dependencies being installed too. A PR merged 6 days ago fixes this https://github.com/kennethreitz/pipenv/pull/972

The good news is that by upgrading pipenv to 8.3.1 will fix this without any other changes.

[sclevine]

Hi @benjefferies,

Thanks for the report! This is fixed on the develop branch, and the fix will be shipped in the next release.

Furthermore, pipenv will now be updated to the latest version in each buildpack release by our pipeline.