Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide support for deploying apps from enterprise github #1832

Closed
cwb124 opened this issue Mar 22, 2018 · 3 comments · Fixed by #4782
Closed

Provide support for deploying apps from enterprise github #1832

cwb124 opened this issue Mar 22, 2018 · 3 comments · Fixed by #4782
Labels
community Community Raised Issue feature-request triage Requires review of inportance and prioritisation

Comments

@cwb124
Copy link

cwb124 commented Mar 22, 2018

Detailed Description

Would love to be able to push apps via stratos from our private enterprise github. Right now it seems as if only public github is available.

Context

Many enterprises have their own github instance to deploy to their on-prem clouds. Think this would be beneficial to them rather than deploying from a file

Possible Implementation

Either add another source type within the Deploy Application page or better yet change the box on the right labeled Public Git URL to Any valid Git repo URL, or something like that and add a place to authenticate to enterprise github.

@irfanhabib
Copy link
Contributor

@cwb124 Deploying using the Public Git URL source type should allow you to deploy from a private GitHub enterprise repository.
Support for private repositories is something we plan to do in the near future.

@cwb124
Copy link
Author

cwb124 commented Mar 22, 2018

Stratos is lacking a way to authenticate to an enterprise github repo. I've added that to the implementation above.

@richard-cox
Copy link
Contributor

@cwb124 Thanks for raising this issue. We previously had quite a cool way to handle github token's via the endpoints page. Bringing this back in would enabled us to deploy apps from private/enterprise github. There's a similar request in #1442, but asking for more basic credential management to use with non-github repos. Ideally we should tackle this at the same time.
In terms of implementing the feature we'd like to tackle this in our new v2 but are first working towards parity with v1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community Raised Issue feature-request triage Requires review of inportance and prioritisation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants