Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pluginChartTest Controller - performance improvement #604

Open
1 task
ibakshay opened this issue Sep 24, 2024 · 0 comments
Open
1 task

pluginChartTest Controller - performance improvement #604

ibakshay opened this issue Sep 24, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@ibakshay
Copy link
Contributor

Priority

(Low) Something is a little off

Description

The pluginChartTest controller does periodic testing for all the plugins that includes helm chart test. The pluginChartTest controller's work-queue keeps increasing when the plugin's test is failing as it is a blocking operation. This is because, when the test fails, there is a retry mechanism inside the test pod and the controller waits till this test pod finishes.

Acceptance Criteria

  • Make sure that the work queue of the pluginChartTest controller is getting drained faster

Potential solutions:

Example of an Alert:

[WARNING] [greenhouse-qa] GreenhouseOperatorWorkqueueNotDrained - Greenhouse Operator controller - pluginChartTest's backlog is not being drained.
:warning: The workqueue backlog of Greenhouse Operator controller - pluginChartTest is not getting drained.
[Prometheus](http://prometheus.greenhouse-qa.eu-nl-1.cloud.sap/graph?g0.expr=sum+by+%28name%29+%28rate%28workqueue_depth%7Bjob%3D%22greenhouse-controller-manager-metrics-service%22%7D%5B5m%5D%29%29+%3E+0&g0.tab=1)

Reproduction steps

1. Add a plugin that has a helm chart test defined. Example [Kube-monitoring plugin](https://github.com/cloudoperators/greenhouse-extensions/tree/main/kube-monitoring/charts/templates/tests)
2. tweak the helm chart of the test plugin in such a way that the helm chart test fails for this plugin

Manifests

No response

Screenshots

![DESCRIPTION](LINK.png)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant