Avoid creating alarms for zero thresholds

[adamantike]

what

This change allows users to disable some of the alarms, by providing zero threshold.

why

At the moment, setting zero as threshold (e.g. to disable alarms on low CPU utilization) still creates the alarm, and incurs in CloudWatch cost for a no-op alarm.

[joe-niland]

@adamantike sorry for the delay in reviewing this! Practically, this looks fine to me, but do you think it could be a breaking change for some users?

[joe-niland]

@adamantike also it looks like the workflows may be out of date. Would you mind running:

make init
make github/init
make readme

Thanks

[adamantike]

I just updated the workflows and Readme, thanks for the heads up!

I don't consider this a breaking change, but a fix instead. Threshold variables are positive integers by default, so this code will only affect users that have explicitly set them as zero.

For those users, I assume zero is being used to disable the alarm for the low thresholds, as they wouldn't be triggering with the current implementation in main. For high thresholds, setting it as zero shouldn't be common, as the alarm would be consistenly triggered.

[adamantike]

@joe-niland, gentle ping. Let me know if there's anything else I can do to move this forward.

[joe-niland]

/terratest

[joe-niland]

@adamantike Waiting on #41 so the tests will run

[hans-d]

@adamantike @joe-niland is merged. Can you update this pr ?

[mergify]

Thanks @adamantike for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

Tip

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

[adamantike]

Just rebased this PR!

[Gowiem]

LGTM

[Gowiem]

/terratest

[rkul]

Could someone clarify when it is going to be released?

[Gowiem]

Ah @rkul this should have already been released, but seems there is an issue with our automation. We'll look into it. I'll circle back.

[rkul]

@Gowiem hello! Just wanted to kindly ask do you have any updates here?

[GabisCampana]

@goruha

[adamantike]

I can see version 0.13.0 has been released 5 days ago. Thank you!