Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tag attribute on autoscaling_group is deprecated #12

Open
etienne-napoleone opened this issue Apr 20, 2023 · 8 comments
Open

tag attribute on autoscaling_group is deprecated #12

etienne-napoleone opened this issue Apr 20, 2023 · 8 comments
Labels
bug 🐛 An issue with the system

Comments

@etienne-napoleone
Copy link

Describe the Bug

The autoscaling_group_tags output takes data from aws_autoscaling_group.default[0].tags but tags is deprecated and triggers a warning

Expected Behavior

Does not use deprecated values and doesn't trigger warnings

Steps to Reproduce

create a ECS cluster using the module

Screenshots

image

Environment

No response

Additional Context

No response

@etienne-napoleone etienne-napoleone added the bug 🐛 An issue with the system label Apr 20, 2023
@etienne-napoleone etienne-napoleone changed the title tag attribute on autoscale_group is deprecated tag attribute on autoscaling_group is deprecated Apr 20, 2023
@dgokcin
Copy link

dgokcin commented May 24, 2023

also come across to this deprecation notice, looking forward for an update!

@metropolis-ameer
Copy link

metropolis-ameer commented May 26, 2023

not a deprecation notice anymore, now it's a full scale error.

│ Error: Unsupported argument
│ 
│   on .terraform/modules/ecs_cluster.autoscale_group/main.tf line 244, in resource "aws_autoscaling_group" "default":
│  244:   tags = flatten([
│ 
│ An argument named "tags" is not expected here.

@justinhauer
Copy link

@metropolis-ameer @dgokcin @etienne-napoleone is there any way around this error?

@metropolis-ameer
Copy link

I went vanilla terraform. You could use the main.tf file from the cloudposse repository and leave out the auto scaling resource for quicker turnaround. On a phone, so can't be more specific at this moment.

@dgokcin
Copy link

dgokcin commented Jun 6, 2023

@metropolis-ameer @dgokcin @etienne-napoleone is there any way around this error?

I pinned the module I am using to 4.x

@lancekuo
Copy link

@dgokcin, can you describe in more detail how you pinned the module please?

@dgokcin
Copy link

dgokcin commented Jun 15, 2023

@lancekuo sure

we are using terragrunt as a wrapper on top of terraform. after the provider 5 upgrade, I made the following change in my versions.tf file so that IT uses 4.x but not 5.x

image

@lancekuo
Copy link

Brilliant! Thank you so much! @dgokcin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An issue with the system
Projects
None yet
Development

No branches or pull requests

5 participants