Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add throughput option to block_device_mappings #53

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

Moncky
Copy link
Contributor

@Moncky Moncky commented Sep 5, 2024

what

This change adds the through put option to the ebs block_device_mappints object in the capacity_providers_fargate_ec2 variable

why

Support to tune the throughput of the ebs volumes was added to the autoscaling group module in version 0.37.1. As it is not defined in the option block here its not passed through during an execution.

references

Release notes for 0.37.1 of cloudposse/terraform-aws-ec2-autoscale-group

Closes #52

@Moncky Moncky requested review from a team as code owners September 5, 2024 14:48
@mergify mergify bot added the triage Needs triage label Sep 5, 2024
@GabisCampana
Copy link

@Benbentwo

@gberenice
Copy link
Contributor

@Moncky could you please add descriptions for the inputs in examples/complete/variables.tf to satisfy this check?

Running input-descriptions in /__w/terraform-aws-ecs-cluster/terraform-aws-ecs-cluster/examples/complete
1..1
Test: check if terraform inputs have descriptions
availability_zones is missing a description
region is missing a description

Should be like (ensure that the code is formatted by running terraform fmt):

variable "region" {
  type        = string
  description = "AWS region"
}

variable "availability_zones" {
  type        = list(string)
  description = "List of Availability Zones IDs (e.g. `['us-east-1a', 'us-east-1b', 'us-east-1c']`)"
}

Thanks a lot in advance!

@gberenice
Copy link
Contributor

/terratest

2 similar comments
@gberenice
Copy link
Contributor

/terratest

@gberenice
Copy link
Contributor

/terratest

@gberenice gberenice merged commit cdd8830 into cloudposse:main Sep 12, 2024
15 checks passed
@mergify mergify bot removed the triage Needs triage label Sep 12, 2024
Copy link
Contributor

These changes were released in v0.7.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Throughput for ebs volumes not passed to autoscale group
3 participants