Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing option for repositoryCredentials #19

Closed
waeltken opened this issue Jan 21, 2019 · 2 comments
Closed

Missing option for repositoryCredentials #19

waeltken opened this issue Jan 21, 2019 · 2 comments
Assignees

Comments

@waeltken
Copy link

"containerDefinitions": [
    {
        "image": "private-repo/private-image",
        "repositoryCredentials": {
            "credentialsParameter": "arn:aws:secretsmanager:region:aws_account_id:secret:secret_name"
        }
    }
]

https://docs.aws.amazon.com/AmazonECS/latest/developerguide/private-auth.html

@jc-asdf
Copy link
Contributor

jc-asdf commented Mar 20, 2019

I've addressed this in #24; would love a review. I'm using my fork of it in a project and it works well.

@aknysh aknysh self-assigned this Mar 20, 2019
@aknysh
Copy link
Member

aknysh commented Mar 21, 2019

addressed in #24

@aknysh aknysh closed this as completed Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants