Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ✨ added restart policies #192

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: ✨ added restart policies #192

wants to merge 4 commits into from

Conversation

JaydenMaalouf
Copy link

@JaydenMaalouf JaydenMaalouf commented Sep 9, 2024 •
edited by nitrocode
Loading

what

Adds container restart policies to the container definition

why

This feature was introduced by AWS recently but has not made its way to this container

references

@JaydenMaalouf JaydenMaalouf requested review from a team as code owners September 9, 2024 05:30
@mergify mergify bot added the triage Needs triage label Sep 9, 2024
Gowiem
Gowiem requested changes Sep 9, 2024
View reviewed changes
Copy link
Member

@Gowiem Gowiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, we need to run some automation to pass our tests. Mind doing the following locally, adding + committing the result, and pushing to your branch?

make init
make readme

Thanks!

variables.tf

variable "restart_policy" {
type = object({
enabled = optional(bool)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this variable be valid if something is supplied, but enabled is left out? Maybe this should be the one required argument to this var?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'm not sure - I just went off what the AWS Console generated haha
I can make this one non-optional if that is preferred?

@JaydenMaalouf
Copy link
Author 

make init
make readme

Seems init and readme are not valid Makefile targets in the root
init appears to be valid int he test folder but no readme still
Is there something I'm missing?

@Gowiem
Copy link
Member

Gowiem commented Sep 13, 2024

@JaydenMaalouf I wonder if you have a bad version of make? This line here adds the init target. Can you mess around with installing latest version of make on your machine and try again?

@JaydenMaalouf
Copy link
Author

I wonder if you have a bad version of make?

Turns out the issue was running it on a Windows shell. Switched to WSL and reran make. Seemed to work!

@goruha
Copy link
Member

goruha commented Sep 17, 2024

@JaydenMaalouf could you pls add a description to this input
https://github.com/cloudposse/terraform-aws-ecs-container-definition/blob/main/examples/complete/variables.tf#L1

I know that's not a part of the PR changes, but unfortunately, we test all terraform files and have such side effects.
cc @Gowiem

@mergify Mergify
Copy link

mergify bot commented Sep 19, 2024

💥 This pull request now has conflicts. Could you fix it @JaydenMaalouf? 🙏

@mergify mergify bot added the conflict This PR has conflicts label Sep 19, 2024
@mergify mergify bot removed the conflict This PR has conflicts label Sep 23, 2024
@the-lay
Copy link

the-lay commented Oct 8, 2024

Is there anything that can be done to expedite this PR? It seems like it's already complete, but happy to contribute.

@Gowiem Gowiem added minor New features that do not break anything feature New functionality labels Oct 8, 2024
@Gowiem
Copy link
Member

Gowiem commented Oct 8, 2024

/terratest

@the-lay
Copy link

the-lay commented Oct 16, 2024 •
edited
Loading

Hey @JaydenMaalouf any chance you could run terraform fmt for examples/complete/variables.tf? It seems that's the reason that the tests have failed.

Apologies for pinging directly - just very interested in having this feature available :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gowiem Gowiem Gowiem requested changes

@gberenice gberenice Awaiting requested review from gberenice gberenice is a code owner automatically assigned from cloudposse/contributors

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
feature New functionality minor New features that do not break anything triage Needs triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add RestartPolicy to container definition
4 participants
@JaydenMaalouf @Gowiem @goruha @the-lay