Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra Parameters #80

Closed
osterman opened this issue Jun 15, 2020 · 0 comments · Fixed by #81 or #84
Closed

Extra Parameters #80

osterman opened this issue Jun 15, 2020 · 0 comments · Fixed by #81 or #84

Comments

@osterman
Copy link
Member

osterman commented Jun 15, 2020

Describe the Feature

Support a new parameter named container_definition which is an object. This would allow absolutely any parameter to be passed to the module, or to override the behavior of the module on any property

Expected Behavior

Merge this container_definition map with the settings computed by this module.

Use Case

Basically, this is an escape hatch to allow users to do anything they want, but still be able to use documented named input variables for common use-cases.

Describe Ideal Solution

https://github.com/cloudposse/terraform-aws-ecs-container-definition/blob/master/main.tf#L67

variable "container_definition" {
  default = {}
  description = "Container definition overrides"
}
 json_map = jsonencode(local.container_definition, var.container_definition)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant