Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed deprecated template provider #41

Closed
wants to merge 3 commits into from
Closed

Removed deprecated template provider #41

wants to merge 3 commits into from

Conversation

nadenf
Copy link

@nadenf nadenf commented Mar 31, 2021

what

  • Removes references to the hashicorp/template provider which is deprecated.

why

  • So we can use module on M1 Macs.

references

@nadenf nadenf requested review from a team as code owners March 31, 2021 08:03
@nadenf nadenf requested review from jhosteny and brcnblc and removed request for a team March 31, 2021 08:03
@Gowiem
Copy link
Member

Gowiem commented Apr 1, 2021

/test all

@Gowiem
Copy link
Member

Gowiem commented Apr 2, 2021

/rebuild-readme

@Gowiem
Copy link
Member

Gowiem commented Apr 2, 2021

/test readme

@Gowiem
Copy link
Member

Gowiem commented Apr 2, 2021

@nadenf could you run the following commands locally and commit:

make init
make pr/auto-format

Normally our CI would do this for you but you have not allowed "maintainers" to edit your PR branch

@Gowiem Gowiem self-requested a review April 2, 2021 21:18
@nadenf
Copy link
Author

nadenf commented Apr 3, 2021

@Gowiem .. I don't see any checkbox to allow access. And when I run make/pr-autoformat the following error message:

Starting cloudposse/build-harness:slim-sha-bb66c2f
docker run --name build-harness \
		--rm -it \
		-e PACKAGES_PREFER_HOST=true \
		-e AWS_ACCESS_KEY_ID -e AWS_SECRET_ACCESS_KEY -e AWS_SESSION_TOKEN -e TERM -e AWS_PROFILE -e AWS_REGION -e AWS_DEFAULT_PROFILE -e AWS_DEFAULT_REGION -e AWS_CONFIG_FILE -e AWS_SHARED_CREDENTIALS_FILE \
		 \
		-v /Volumes/Docker/Developer/harana-oss/terraform-aws-multi-az-subnets:/opt \
		--workdir /opt \
		--entrypoint /usr/bin/make \
		cloudposse/build-harness:slim-sha-bb66c2f terraform/fmt readme
Unable to find image 'cloudposse/build-harness:slim-sha-bb66c2f' locally
docker: Error response from daemon: manifest for cloudposse/build-harness:slim-sha-bb66c2f not found: manifest unknown: manifest unknown.
See 'docker run --help'.
make: *** [build-harness/runner] Error 125

@Nuru
Copy link
Contributor

Nuru commented Apr 7, 2021

@nadenf Sorry, you hit a bug in build-harness which is now fixed. Please run

make init
make pr/auto-format

again

@mergify
Copy link

mergify bot commented Apr 7, 2021

This pull request is now in conflict. Could you fix it @nadenf? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module is unusable on Apple M1 Macs
3 participants