Add cidr block output per AZ #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdobbyn
requested review from
dotCipher and
brcnblc
and removed request for
a team
|
/test all |
|
Anything extra I need to do here @nitrocode? I'll add a test for this. |
|
I see that I missed some of what was done here in the module around outputs, fixing and adding tests now. |
- Add the output `az_subnet_cidr_blocks` - Add tests to verify the output for the complete example
|
/test all |
nitrocode
approved these changes
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
No resource changes at all.
Add
subnet_cidr_blockto theoutput_mapandaz_subnet_cidr_blocksas an output.why
This is helpful when you want to assign something like the 4th IP in a subnet rather than allowing DHCP to do it's thing.
references
n/a