Add ipv6 support #55
Merged
Add ipv6 support #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdobbyn
requested review from
srhopkins and
3h4x
and removed request for
a team
|
ping @srhopkins |
|
Ping @Gowiem. Only because you were interacting with someone in a previous PR and no one seems to be looking at this :/. |
aknysh
reviewed
Oct 12, 2021
Co-authored-by: Andriy Knysh <aknysh@users.noreply.github.com>
nitrocode
reviewed
Oct 12, 2021
nitrocode
reviewed
Oct 12, 2021
nitrocode
reviewed
Oct 12, 2021
| variable "ipv6_cidr_block" { | ||
| type = string | ||
| description = "Private IPv6 CIDR block" | ||
| } |
There was a problem hiding this comment.
This should contain the same additional vars as variables.tf
There was a problem hiding this comment.
I included the enabled portion because we can use that flag, though the ipv6 block is unknown until the vpc is created so I left this out.
nitrocode
reviewed
Oct 12, 2021
nitrocode
reviewed
Oct 12, 2021
|
/test all |
nitrocode
reviewed
Oct 13, 2021
|
/test all |
|
Any updates on this PR? |
nitrocode
requested review from
aknysh and
nitrocode
and removed request for
3h4x
aknysh
approved these changes
Apr 8, 2022
|
Thanks @cdobbyn for your contribution, your persistence, and your patience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
::/0) if others think this is necessary. There is no concept of NAT in AWS VPC IPv6.why
references