Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SageMaker Model PrimaryContainer Definition Required #1729

Closed
mneil opened this issue Jun 16, 2020 · 1 comment
Closed

SageMaker Model PrimaryContainer Definition Required #1729

mneil opened this issue Jun 16, 2020 · 1 comment

Comments

@mneil
Copy link

mneil commented Jun 16, 2020

According to the cloudformation docs https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-sagemaker-model.html#cfn-sagemaker-model-primarycontainer the "PrimaryContainer" attribute is not required.

However, troposphere is marking it as required. https://github.com/cloudtools/troposphere/blob/master/troposphere/sagemaker.py#L79

I'm unable to launch a stack without a container definition.

I can open up a PR to resolve this but I know a lot of the code is autogenerated. I was going to simply flip True to False in the Model definition. I can do that if it's the correct location to change the requirements for the future. Otherwise, I'll hold off.

Thanks!

@markpeek
Copy link
Member

Pushed a quick fix for this one. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants