ECS LoadBalancer 'LoadBalancerName' property takes an array

[sangngh]

Hi all,

A bit new to troposphere and python development in general so excuse my ignorance..

We are trying to use troposphere to create an ECS cloud formation stack and running into some issues with setting up load balancing.
The current issue is that the ECS LoadBalancer class takes an array of string for the 'LoadBalancerName' property and its used in the ECS Service class, it generates a cloud formation template that is invalid.

The invalid cfn snippet looks like this:

        "stubvalidatorservice": {
            "Properties": {
                "Cluster": {
                    "Ref": "MobiusEcsCluster"
                },
                "DesiredCount": 3,
                "LoadBalancers": [
                    {
                        "ContainerName": "stubvalidator",
                        "ContainerPort": 9000,
                        "LoadBalancerName": [
                            "stubvalidatorELB"
                        ]
                    }
                ],
                "TaskDefinition": {
                    "Ref": "stubvalidatortaskdef"
                }
            },
            "Type": "AWS::ECS::Service"
        },

Cloud formation complains with this error:

CREATE_FAILED   AWS::ECS::Service   stubvalidatorservice    Value of property LoadBalancerName must be of type String

My troposphere codes looks like this:

ecs_lb = ecs.LoadBalancer(service_name + 'EcsElb', ContainerName=service_name, ContainerPort=container_config['port'], LoadBalancerName=[self.lb.title])

[markpeek]

Please try this change and let me know if it works:

--- a/troposphere/ecs.py
+++ b/troposphere/ecs.py
@@ -12,7 +12,7 @@ class LoadBalancer(AWSProperty):
     props = {
         'ContainerName': (basestring, False),
         'ContainerPort': (network_port, False),
-        'LoadBalancerName': ([basestring, Ref], False),
+        'LoadBalancerName': (basestring, False),
     }

[sangngh]

I made the change it seems to fix the issue. I just wanted to know if this change will make into a future troposphere release.

Thanks
Sang