Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Throughput for gp3 ebs volumes #1873

Merged
merged 1 commit into from
Mar 13, 2021

Conversation

mtougeron
Copy link
Contributor

This allows setting the Throughput field for the AWS gp3 ebs volumes when creating an Ec2EBSBlockDevice.

@markpeek
Copy link
Member

I'm not seeing this in the docs or in the specification files. Could you let me know where you saw this property documented?

@mtougeron
Copy link
Contributor Author

It's unfortunately not available for all EBS resources but it is for some like LaunchTemplateEbsBlockDevice which use the same EBSBlockDevice other EC2 resources. Like Iops being conditional based on the volume type I thought it would be fine to add Throughput as conditional as well.

Thoughts?

@markpeek
Copy link
Member

Got it. Thanks for the quick reply. I'll merge it now. I'll have to think about breaking these out separately in a future major version (since it will be a breaking change). Any thoughts on this?

@markpeek markpeek merged commit 789b449 into cloudtools:master Mar 13, 2021
@mtougeron mtougeron deleted the gp3-volumes branch March 13, 2021 20:08
@mtougeron
Copy link
Contributor Author

Got it. Thanks for the quick reply. I'll merge it now. I'll have to think about breaking these out separately in a future major version (since it will be a breaking change). Any thoughts on this?

Yeah, I was a little torn on this myself. I'm going to be opening a ticket with AWS for a bug report that their API doesn't allow setting that value at instance creation. :(

@mtougeron
Copy link
Contributor Author

thanks for merging the PR!

@Asura9
Copy link

Asura9 commented May 12, 2021

This not applies to AWS::EC2::Volume, it affects only AWS::EC2::LaunchTemplate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants