FromPort, ToPort and Egress are optional #463
Conversation
Those 3 properties are flagged as optional in AWS's docs.
|
This should fix #392 |
Made a mistake in my previous commit - this one actually reflects the docs.
Subclassed Template into an object able to analyze and create Troposphere objects based on an existing CloudFormation Template. Conditions are missing - working on it.,
This removal helps inspection of the Configuration class to enable automating troposphere object creation.
Added UpdatePolicy, CreationPolicy, DeletionPolicy, Metadata and DependsOn discovery.
Special AWSHelperFn typically take lowercased parameters, but templates use uppercase. for this reason we cannot map to most of them, so we fallback with a generic one. This might not work for all types if they do extra processing in their init routine but makes tests pass :)
S3 Bucket used a 'name' argument and put that into the 'title' of the AWSBaseObject. This modification is backward compatible and allows 'name' to be substituted by 'title' in the kwargs.
AWSHelperFn are ignored in AWSObjectBase, it's not necessary to flag them in props anymore.
|
Ow, sorry, I'm a total noob with github, I wanted to do a different PR with this last change; I'll be more careful next time. |
|
@muikrad It would be best to back out the more global import changes from this PR and keep these issues separate. If there is a dependency issue you're worried about then I'll merge #463 first (just the port changes) and then you can apply your import change on top. Thanks. |
|
@markpeek Sorry I'm learning github TODAY 😭 I reverted the last change which wasn't supposed to be in here at all (import_cloudformation). Do you want to merge the trivial AWSHelperFn removals from this PR or should I (learn more github and...) revert and move that to a separate commit? |
|
@muikrad I pulled out the port changes and the AWSHelperFn as separate commits after squashing things. Please check out and approve the two commits in this branch to make sure I got the right changes: https://github.com/cloudtools/troposphere/tree/muikrad-463 BTW, for forked projects I find it best to create non-master branches to handle PR's. That way you can always sync the real master back into your forked repo. |
|
It looks OK to me. Sorry for the fiasco and thanks for the help and advice. |
|
The port changes and the AWSHelperFn have been pushed onto master as separate commits. Thanks for the changes! |
Those 3 properties are flagged as optional in AWS's docs.