Adding EgressOnlyInternetGatewayId to EC2::Route #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
changed the title
markpeek
reviewed
Jul 13, 2017
| @@ -317,6 +317,7 @@ class Route(AWSObject): | |||
| props = { | |||
| 'DestinationCidrBlock': (basestring, False), | |||
| 'DestinationIpv6CidrBlock': (basestring, False), | |||
| 'EgressOnlyInternetGatewayId': (basestring, False), | |||
There was a problem hiding this comment.
Would you like to add additional validation? You can follow the same pattern for the Destination* props in the validate method. Per the docs:
Required: Conditional. You must specify only one of the following properties: EgressOnlyInternetGatewayId, GatewayId, InstanceId, NatGatewayId, NetworkInterfaceId, or VpcPeeringConnectionId.
|
Excellent. Thank you for the PR and the extra validation. |
dguinane
pushed a commit
to 7digital/troposphere
that referenced
this pull request
Jul 14, 2017
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.