Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Batch Support #796

Merged
merged 1 commit into from
Sep 23, 2017
Merged

AWS Batch Support #796

merged 1 commit into from
Sep 23, 2017

Conversation

cwgem
Copy link
Contributor

@cwgem cwgem commented Aug 31, 2017

Support AWS batch per issue #781. This is somewhat of a draft of the whole thing to make sure the overall structure looks sane before I go up and CloudFormation all the things. Note that for the JobQueue resource's state property I diverged from the CF documentation and used the REST API documentation for CreateJobQueue which states that ENABLED or DISABLED are valid values.

The following resources are added:

The following property types are added:

If this looks good I'll go ahead and do the runtime testing. As for updating README.md's list of supported resources do you want that as a separate commit or should I just squash with the python code commit?

* This adds AWS batch support
* Includes all CF resource types and all property types
* Based off CF documentation
@markpeek
Copy link
Member

markpeek commented Sep 1, 2017

This looks excellent. Note: I might have combined the state validators, added enabled/disabled constants, and possibly alphabetized the various props (the purest in me would prefer the AWS docs to be in alphabetical order but I know why you chose that order). I'm not asking for changes since this looks good to go. Feel free to add additional runtime and I'll commit. Thank you for this change! How about opening up a README issue and I'll update with the various new resources in 1 commit.

@cwgem
Copy link
Contributor Author

cwgem commented Sep 1, 2017

@markpeek Let me do re-order on the props and some of the objects then to have them in alphabetical order (though the objects I can only re-order to the point of python being able to properly resolve definitions). To make an easier read I'll toss in a few comments to break up the file by Batch resource. I agree on the constants an validators so I'll go ahead and update that as well.

For the runtime testing it's going to take a bit since putting this all together into a template will be rather time consuming. Possibly middle of next week?

Okay on the README issue. I though there might be other services that got left out but wanted to get this finished out and didn't have a chance to do a full comparison.

@markpeek markpeek merged commit f84a804 into cloudtools:master Sep 23, 2017
@markpeek
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants