Add Fargate support to ECS types #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the update @ejholmes. To complete Fargate support I think some changes needed to be done on the Task Definition side as well especially for supporting CPU and Memory fields. http://docs.aws.amazon.com/AmazonECS/latest/APIReference/API_TaskDefinition.html |
|
Good call! I've updated, and add an example for launching nginx using Fargate (tested in CloudFormation). |
markpeek
reviewed
Dec 1, 2017
troposphere/ecs.py
Outdated
| 'NetworkMode': (basestring, False), | ||
| 'PlacementConstraints': ([PlacementConstraint], False), | ||
| 'RequiresCompatibilities': (list, False), |
There was a problem hiding this comment.
Instead of "list" this should be "[basestring]" which will do checks on the elements as well.
|
@markpeek fixed |
|
Thanks @ejholmes for the Fargate changes. And appreciate the input from @shyamvala as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the ECS Service type to support the new properties for enabling VPC networking and Fargate support.