Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: How to define the GraphViz record structure? #19

Closed
4 tasks
clemens-tolboom opened this issue Dec 29, 2013 · 5 comments
Closed
4 tasks

WIP: How to define the GraphViz record structure? #19

clemens-tolboom opened this issue Dec 29, 2013 · 5 comments

Comments

@clemens-tolboom
Copy link
Collaborator

As #9 was just a tiny start let's define how to build this new class.

  • Define a class GraphVizRecord
  • Define a subclass for a GraphvizDatabaseRecord structure?
  • Define a subclass for a Class Diagram?
  • Apply the subclass ClassDiagram?

Relates to

@clemens-tolboom
Copy link
Collaborator Author

While writing the issue summary I guess starting directly with a GraphVizRecord is too quick.

I should reread http://www.graphviz.org/content/node-shapes#record

rlabel :== field ( '|' field )*
field :== fieldId or '{' rlabel '}'
fieldId :== [ '<' string '>'] [ string ]

Has the usual escape sequences.

  • do we have covered all these in GraphViz?

It also mentions port position to draw an edge to a field within the record.

So maybe we can build the tree using Graph with Layout() and using subclassing?

@clue
Copy link
Owner

clue commented Dec 29, 2013

Currently, the ClassDiagramBuilder is quite difficult to work with, as it doesn't even remotely resemble a SOLID design :)

I think we should start off by refactoring the code into smaller units:

@clemens-tolboom
Copy link
Collaborator Author

Let's close this issue as both graphviz as we think as stated on http://www.graphviz.org/content/node-shapes

The record-based shape has largely been superseded and greatly generalized by HTML-like labels.

@clemens-tolboom
Copy link
Collaborator Author

Subgraphs are requested in graphp/graph#36

@clue
Copy link
Owner

clue commented Jul 7, 2016

Closed via #23.

@clue clue closed this as completed Jul 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants