Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Set weight helpers to new Algorithm\Weight #33

Merged
merged 4 commits into from
Jun 1, 2013

Conversation

clue
Copy link
Member

@clue clue commented Jun 1, 2013

  • Move Graph balance helpers to new Algorithm\Weight
  • 100% code coverage
  • Documentation / changelog

Also refs #27.

@clue
Copy link
Member Author

clue commented Jun 1, 2013

Remove [WIP] marker, now that all tasks are completed.

@clemens-tolboom, care to review and merge?

namespace Fhaculty\Graph\Algorithm;

use Fhaculty\Graph\Set;

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for whitespace line.

@clemens-tolboom
Copy link
Collaborator

Hmm ... maybe just ignore coding style and documentation. This is a move of code.

So let's pull this in.

clemens-tolboom added a commit that referenced this pull request Jun 1, 2013
Move Set weight helpers to new Algorithm\Weight
@clemens-tolboom clemens-tolboom merged commit 84a1711 into master Jun 1, 2013
@clue
Copy link
Member Author

clue commented Jun 1, 2013

Thanks for the review and merge. I've addressed your concerns and added some documentation to the merged master.

@clue clue deleted the move-algo-weight branch June 1, 2013 21:10
clue added a commit that referenced this pull request Jun 3, 2013
Move Set weight helpers to new Algorithm\Weight
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants