Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow GADM IDs for geographical locations #688

Open
bethard opened this issue Oct 10, 2019 · 2 comments
Open

allow GADM IDs for geographical locations #688

bethard opened this issue Oct 10, 2019 · 2 comments
Assignees

Comments

@bethard
Copy link
Contributor

bethard commented Oct 10, 2019

We need to allow GADM IDs (e.g., ETH.9.7.3_1) in addition to GeoNames IDs (e.g., 6783700) for normalizing locations. The geonorm library already supports this. (No changes were needed.) I have constructed a new geonorm index that includes all of GeoNames, plus some Ethiopian woredas from GADM that weren't in GeoNames:

http://clulab.cs.arizona.edu/models/geonames+woredas.zip

To load this new index, some changes to Eidos are needed. Eidos assumes that geo IDs will be Ints:

https://github.com/clulab/eidos/blob/master/src/main/scala/org/clulab/wm/eidos/context/GeoNormFinder.scala#L23
https://github.com/clulab/eidos/blob/master/src/main/scala/org/clulab/wm/eidos/context/GeoNormFinder.scala#L137
etc.

Those Ints will need to be changed to Strings to work with the new index.

As far as I know, there was no reason to use Ints in the first place, so while it's a pain to change a bunch of types in Eidos, I think a String is a better representation for an ID anyway.

@EgoLaparra: can you look into this today? I believe @kwalcock wants all changes in today so that he can merge them, run Eidos on the documents over the weekend, and send Ben the new results on Monday.

@kwalcock
Copy link
Member

Thanks again for the heads up. It probably won't be starting until tomorrow. There are still documents coming in and ontologies being changed.

@EgoLaparra
Copy link
Contributor

Yes, I start working on this right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants