-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Time value changes #861
Comments
In case it helps, here is another example:
becomes
despite a DCT of
The sentence is |
becomes
for text
|
So it seems to always have to do with a day of the week and possible confusion about whether the previous value or the next value is chosen. I don't recall checking in any recent code changes in this area, especially not since last Thursday. |
@kwalcock, I've moved the issue here since the problem is not caused by the neural parser. |
Fwiw, it seems to me that the second reading should be the correct one, since it references a time before publication. I think this is related to the heuristic in SUTime that resolves days of the week such as "Monday". But I can't see why this would change, if we didn't change CoreNLP versions... |
Thanks for moving it to the right place. I'll try to see if it can be reproduced, perhaps on the same day, so that I'm absolutely certain that the code hasn't changed. |
This phenomenon does appear to be repeatable. I'm trying to isolate the situation. |
If Eidos reads, serially, the files 1742d787c22e9873c4bf9558e456ddd2, then 73f374515fed56aac5979d847591a7f8, and again 1742d787c22e9873c4bf9558e456ddd2, the two reads of the one file are different. Something must be keeping state around. The last time it happened, something from Stanford was running into an unknown word, noting it, and then not considering it unknown the next time around and working differently. I think that problem would happen when the same file was read twice in a row. That's not the case here. 1742d787c22e9873c4bf9558e456ddd2.json.txt |
These texts are adequate:
and
They do not need to go through Eidos. A pass through Processors is enough. Only these stages are necessary:
|
It's looking like an edu.stanford.nlp.ling.tokensregex.Env is being maintained. This has a variable for TUESDAY which has a value which in turn has tags. There's a tag for resolveTo which is initially missing so that a default value of SUTime.RESOLVE_TO_CLOSEST is used. Sometime later in execution, that gets changed to RESOLVE_TO_PAST. It seems like it is getting incorporated into the environment and then not being reset/cleared properly. |
I read the same set of documents on Thursday (May 14) and again on Monday (May 18). The times have changed in the output. For the sentence
February 21, 2015 (ADDIS ABABA) - South Sudan peace talks aimed at ending the more than 14-month-long conflict in the young East African nation have been postponed until Monday.
the first reading isand the second reading is
The document does have a DCT:
This is with
useNeuralParser = false
. I don't think that anything has been changed in the configuration. Any idea what might cause this?The text was updated successfully, but these errors were encountered: