Skip to content

Commit

Permalink
replaced FIND_IN_SET by IN in queries that needed to be changed in th…
Browse files Browse the repository at this point in the history
…is PR
  • Loading branch information
cmadjar committed Nov 13, 2018
1 parent 54f739c commit 1ebaad5
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion modules/dashboard/php/dashboard.class.inc
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ class Dashboard extends \NDB_Form
LEFT JOIN session s ON (flag.SessionID=s.ID)
LEFT JOIN candidate c ON (c.CandID=s.CandID)
LEFT JOIN Project p ON (c.ProjectID=p.ProjectID )
WHERE FIND_IN_SET(s.CenterID, :siteID)
WHERE s.CenterID IN (:siteID)
AND s.Active='Y' AND c.Active='Y'",
array('siteID' => implode(',', $siteID))
);
Expand Down
4 changes: 2 additions & 2 deletions php/libraries/NDB_BVL_Feedback.class.inc
Original file line number Diff line number Diff line change
Expand Up @@ -469,7 +469,7 @@ class NDB_BVL_Feedback
}
$query .= " WHERE ft.Active ='Y'";
if (!$hasReadPermission===true) {
$query .= " AND FIND_IN_SET (s.CenterID,:CentID)";
$query .= " AND s.CenterID IN (:CentID)";
$qparams['CentID'] = implode(',', $user->getCenterIDs());
}

Expand Down Expand Up @@ -582,7 +582,7 @@ class NDB_BVL_Feedback
$qparams['Username'] = $this->_username;
} else {
$query .= " AND ft.Active ='Y'
AND FIND_IN_SET (s.CenterID,:CentID)";
AND s.CenterID IN (:CentID)";
$qparams['CentID'] = implode(',', $user->getCenterIDs());
}

Expand Down

0 comments on commit 1ebaad5

Please sign in to comment.