missing one #1
Merged
missing one #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmadjar
merged commit db48ab1
into
cmadjar:rename_candidate_CenterID_to_RegistrationCenterID
cmadjar
pushed a commit
that referenced
this pull request
Nov 8, 2021
Fix error ``` PHP Fatal error: Uncaught TypeError: NDB_BVL_Instrument::factory(): Argument #1 ($loris) must be of type LORIS\LORISInstance, string given, called in /var/www/Loris/tools/CouchDB_Import_Instruments.php on line 196 and defined in /var/www/Loris/php/libraries/NDB_BVL_Instrument.class.inc:225 ``` In CouchDB_Import_Instruments.php Fixes aces#7680
cmadjar
pushed a commit
that referenced
this pull request
Nov 8, 2021
When accessing an instrument from RB, I got the error: ``` Fatal error: Uncaught TypeError: Argument 1 passed to ValidatableIdentifier::__construct() must be of the type string, null given, called in /home/driusan/Code/Loris/php/libraries/NDB_BVL_Instrument.class.inc on line 2863 and defined in /home/driusan/Code/Loris/php/libraries/Valida tableIdentifier.php:57 Stack trace: #0 /home/driusan/Code/Loris/php/libraries/NDB_BVL_Instrument.class.inc(2863): ValidatableIdentifier->__co nstruct(NULL) #1 /home/driusan/Code/Loris/src/Middleware/UserPageDecorationMiddleware.php(241): NDB_BVL_Instrument->handle(Object(Laminas\Dia ctoros\ServerRequest)) #2 /home/driusan/Code/Loris/src/Middleware/PageDecorationMiddleware.php(57): LORIS\Middleware\UserPageDecorationMiddle ware->process(Object(Laminas\Diactoros\ServerRequest), Object(NDB_BVL_Instrument_aosi)) #3 /home/driusan/Code/Loris/php/libraries/NDB_Page.cl ass.inc(735): LORIS\Middleware\PageDecorationMiddleware->process(Object(Laminas\Diactoros\ServerRequest), Object(NDB_BVL_Instrument_aosi)) #4 /home/driusan/Code/Loris/php/libraries/NDB_BVL_In in /home/driusan/Code/Loris/php/libraries/ValidatableIdentifier.php on line 57 ``` This fixes the type error so that the instrument page loads.
cmadjar
pushed a commit
that referenced
this pull request
Dec 1, 2022
This fixes the error: ``` <b>Fatal error</b>: Uncaught TypeError: ValidatableIdentifier::__construct(): Argument #1 ($value) must be of type string, int given, called in /var/www/loris/modules/behavioural_qc/php/models/incompletedto.class.inc on line 126 ``` when the module is run on PHP 8.1.
cmadjar
pushed a commit
that referenced
this pull request
Mar 26, 2024
Fix the warnings: ``` <b>Deprecated</b>: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in <b>modules/instrument_list/php/instrument_list_controlpanel.class.inc</b> on line <b>475</b><br /> <br /> <b>Deprecated</b>: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in <b>modules/instrument_list/php/instrument_list_controlpanel.class.inc</b> on line <b>514</b><br /> ``` in PHP 8.2 and above.
cmadjar
pushed a commit
that referenced
this pull request
Aug 7, 2024
Fixes error on statistics page: ``` [CRITICAL] /var/www/Loris/php/libraries/User.class.inc:476: Uncaught TypeError: User::hasProject(): Argument #1 ($projectID) must be of type ProjectID, string given, called in /var/www/Loris/modules/statistics/php/statistics_site.class.inc on line 134 and defined in /var/www/Loris/php/libraries/User.class.inc:476 ``` Fixes aces#9137
cmadjar
added a commit
that referenced
this pull request
Sep 30, 2024
…www/loris/tools/generic_includes.php on line 28" - 26 branch (aces#9317) This fixes the script generic_includes.php that calls the $DB variable before it is defined when calling LorisInstance. Without this fix, anything calling generic_includes.php will trigger the following error: ``` Undefined variable in /var/www/loris/tools/generic_includes.php on line 28 PHP Fatal error: Uncaught TypeError: LORIS\\LorisInstance::__construct(): Argument #1 ($db) must be of type Database, null given, called in /var/www/loris/tools/generic_includes.php on line 27 ```
cmadjar
added a commit
that referenced
this pull request
Oct 1, 2024
…www/loris/tools/generic_includes.php on line 28" - 25 branch (aces#9318) This fixes the script `generic_includes.php` that calls the $DB variable before it is defined when calling LorisInstance. Without this fix, anything calling `generic_includes.php` will trigger the following error: ``` Undefined variable in /var/www/loris/tools/generic_includes.php on line 28 PHP Fatal error: Uncaught TypeError: LORIS\\LorisInstance::__construct(): Argument #1 ($db) must be of type Database, null given, called in /var/www/loris/tools/generic_includes.php on line 27 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.