Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No interaction on websites with frames #122

Open
pjoubert- opened this issue Nov 23, 2017 · 10 comments · Fixed by #320 or #425
Open

No interaction on websites with frames #122

pjoubert- opened this issue Nov 23, 2017 · 10 comments · Fixed by #320 or #425
Labels

Comments

@pjoubert-
Copy link

Besides frames are bad, some websites still use them. I use some of them, where keyboard interactions are just not working at all.

Example website: http://www.angelfire.com/super/badwebs/

tridactyl version: 1.5.1pre409

@Bzly
Copy link
Contributor

Bzly commented Nov 23, 2017

This is already noted directly (albeit titled less accurately) in #67 and indirectly in #28.

From the former:

This is an iframe issue: tridactyl currently loads into only the top level frame.

We're aware of this issue and expect to fix it Soon TM. :)
@cmcaine

@lisael
Copy link

lisael commented Feb 1, 2018

Hi, and thank you for the amazing work.

Besides the fact that only current iframe links are shown with 'f', the main drawback is that we can't navigate between iframes. My trackpad is somehow broken. I sometimes get stuck in a menu or ToC frame and I can't read the content of the website without plugging a mouse. The first quick-win, to me is "just" iframes navigation, relaoding tridactyl in each visited iframe (I have no idea of the amount of work but it looks easier than sharing data among iframes)

@cmcaine
Copy link
Member

cmcaine commented Feb 2, 2018

Thanks for commenting :)

Can you provide us with a link to the site that features the behaviour you describe?

Unfortunately I don't think the quick-win you describe will work: hints wouldn't be emitted properly on multi-frame sites and other issues.

The way to fix it is to bite the bullet and teach Tridactyl about frames properly, but that requires a bunch of changes in messaging and elsewhere to make settings and logic tab or page specific (probably page specific).

@Koushien, your excmd changes would be useful here, actually.

@bovine3dom
Copy link
Member

Unfortunately this was not fixed in #320.

@bovine3dom
Copy link
Member

bovine3dom commented Apr 12, 2018

Somewhat fixed in 15c8c47, but scrolling just scrolls all elements one at a time rather than the one you are focused in / the biggest, so I'll leave this open as I think it could be improved :)

@bovine3dom
Copy link
Member

bovine3dom commented Apr 25, 2018

Scrolling up on http://docs.nvidia.com/cuda/parallel-thread-execution/index.html now scrolls up the table of contents, the page, and then the table of contents again, which is less than ideal.

Edit: reproduce with G and then hold k.

@glacambre
Copy link
Member

glacambre commented Apr 25, 2018

Yep, I'm aware of this issue but I think #35 is more appropriate for this.

However you're right that we still have issues with frames. #412 is an example and maybe #417 too? But since they're more specific about the problem (keyevents) and since scrolling/following hints on the website mentioned by @pjoubert- works quite well now I thought we could close this issue.

@glacambre glacambre added the bug label Jan 31, 2019
@Iey4iej3
Copy link
Contributor

Iey4iej3 commented May 30, 2019

Will we implement the focus back/forward between frames like [f and ]f in vimperator?

@glacambre
Copy link
Member

@FrankEular Are you talking about [[ and ]] which are bound to :followpage prev and :followpage next by default?

@Iey4iej3
Copy link
Contributor

@FrankEular Are you talking about [[ and ]] which are bound to :followpage prev and :followpage next by default?

No, I mean switching the focus of frames. Take the link of the original post as an example: http://www.angelfire.com/super/badwebs/

There are several frames. As far as I remember, I could take advantage of [f and ]f in vimperator to switch between different frames. The upshot of this switching is that, say, I can scroll down/up in the frame.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants