Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest addition of "--nolog" clink breaks cmd prompts #2166

Closed
CollinChaffin opened this issue Sep 15, 2019 · 11 comments
Closed

Latest addition of "--nolog" clink breaks cmd prompts #2166

CollinChaffin opened this issue Sep 15, 2019 · 11 comments

Comments

@CollinChaffin
Copy link

If I simply remove the new "--nolog" from 2 lines in the new init.bat, my powerline/git prompts return to normal. Otherwise, for some reason it breaks them I have not done any debugging yet but since it's reproducible on mult machines I wanted to report it right away.

@daxgames
Copy link
Member

@CollinChaffin I just tried this, no issues. Is it intermittent?

@CollinChaffin
Copy link
Author

No, with powerline prompt set up, Powershell remains unaffected and anything loading clink (only with the new --nolog renders a default prompt and I'll have to retest but now that I think about it, I wonder if clink even injects properly in those cases. I'll update here as soon as I can I apologize I totally meant to provide more debug info but again - making only that change in init.bat removing only the new --nolog and restarting cmder, returned clink-based startup tabs to normal behavior.

@daxgames
Copy link
Member

@CollinChaffin I must be missing something.

The link I posted was powerline for cmder clink. Works fine with --nolog

@daxgames
Copy link
Member

@CollinChaffin

image

@stale
Copy link

stale bot commented Oct 27, 2019

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in a week if no further activity occurs. Thank you for your contribution(s).

@stale stale bot added the 👀 Awaiting Response Waiting to hear back from the issue reporter. label Oct 27, 2019
@daxgames
Copy link
Member

daxgames commented Nov 3, 2019

@CollinChaffin Unable to reproduce this.

@stale stale bot removed the 👀 Awaiting Response Waiting to hear back from the issue reporter. label Nov 3, 2019
@Zorgodon
Copy link

I also have this issue. I only get a lambda, colors and Ctrl+L if I remove --nolog from 2 lines. The lambda is white however, not grey like it should be. I have none of these issues in 161206/1.3.2

@daxgames
Copy link
Member

daxgames commented Jan 5, 2020

@Zorgodon @CollinChaffin Try this

Apparently only Windows 7 is affected by the --no-log issue.

@CollinChaffin
Copy link
Author

@daxgames Good to see this was finally able to be reproduced and fixed with latest PRs but this issue# should have also probably been listed on the changelog along with the later duplicate issue #s. I try to report this stuff quick when I test new builds but for some reason this one was closed as not reproducible, and then months later others opened the exact same issue and only those are listed on the changelog.

I knew it was the issue since I've simply been hand-editing the init bat myself but still run WIN7 on most systems. :)

@daxgames
Copy link
Member

daxgames commented Jan 6, 2020

@CollinChaffin the Windows 7 was the missing detail as it is only Windows 7 that has the problem. Thanks.

@daxgames
Copy link
Member

daxgames commented Jan 6, 2020

As for the changelog it will be updated. I just wanted to get the fix out and tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants