Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On large svn repo prompt with svn status enabled can be slow #2702

Closed
Mikaz-fr opened this issue May 24, 2022 · 5 comments
Closed

On large svn repo prompt with svn status enabled can be slow #2702

Mikaz-fr opened this issue May 24, 2022 · 5 comments

Comments

@Mikaz-fr
Copy link
Contributor

Similarly to #2548 and #1566, on large svn repo fetching the status delay slightly the command prompt display.

I recently updated to Cmder 1.3.19 and was thrilled to see that git status can now be fetched asynchronously using recent clink feature (integrated via #2556).
Is there any plan to provide the same for svn ?

It's good now we can disable in the option the svn status, but having it asynchronously would be even better.

@chrisant996
Copy link
Contributor

There wasn't any plan to do so, because no one had identified it as being a problem that needed solving. 🙃

It's not hard to do. Someone could make the Lua script tweaks and submit a PR.

(I'll see about extending clink-flex-prompt accordingly. Someone could port from there to Cmder. Or if I find myself with extra time, then maybe at some point I can also provide a patch for Cmder, but that's not a priority for me.)

@Mikaz-fr
Copy link
Contributor Author

I've made an attempt to solve this for svn similarly to how it's done for git. I've open pull request #2703.
Please let me know if you would have done that differently.

@chrisant996
Copy link
Contributor

The changes look good to me!

@Mikaz-fr
Copy link
Contributor Author

Awesome. Feel free to close once PR is merged. Will get the next release with this feature :)

@Mikaz-fr
Copy link
Contributor Author

This change is now part of release https://github.com/cmderdev/cmder/releases/tag/v1.3.20.
This issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants