Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

./build.ps1 -verbose fails looking for msbuild.exe #2757

Closed
1 of 3 tasks
daxgames opened this issue Oct 16, 2022 · 3 comments
Closed
1 of 3 tasks

./build.ps1 -verbose fails looking for msbuild.exe #2757

daxgames opened this issue Oct 16, 2022 · 3 comments

Comments

@daxgames
Copy link
Member

daxgames commented Oct 16, 2022 •
edited
Loading

Purpose of the issue

  • Bug report (encountered problems/errors)
  • Feature request (request for new functionality)
  • Question

Version Information

Cmder: master

Description of the issue

./build.ps1 -verbose fails looking for msbuild.exe if running from a simple Powershell session that is not msbuild aware. This should only happen if the -compile switch is also used.
@DRSDavidSoft DRSDavidSoft mentioned this issue Oct 16, 2022
Merged
@DRSDavidSoft
Copy link
Contributor

@daxgames Thanks, PR #2758 will fix this issue.

@daxgames daxgames mentioned this issue Oct 16, 2022
Closed
@daxgames
Copy link
Member Author

@DRSDavidSoft You are too fast. 🥇 Initially just documenting so I would not forget it but I was fixing after seeing the issue in the code.

@DRSDavidSoft
Copy link
Contributor

Fixed by #2578.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

do not fail on msbuild if not compiling daxgames/cmder
2 participants
@DRSDavidSoft @daxgames