Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site isn't very mobile friendly #15

Closed
JoshuaKGoldberg opened this issue Mar 13, 2017 · 8 comments · Fixed by #22
Closed

Site isn't very mobile friendly #15

JoshuaKGoldberg opened this issue Mar 13, 2017 · 8 comments · Fixed by #22
Assignees

Comments

@JoshuaKGoldberg
Copy link

I mentioned cmder to a friend recently. Their reaction was to look it up on their phone. This was the experience they got:

image
image

😦

@JoshuaKGoldberg
Copy link
Author

Some thoughts on ways to improve this:

  • Use HTML elements + CSS to create the window in main.jpg
    • ...then use JavaScript to animate someone typing in random commands, maybe? That effect always looks cool...
  • After ^, hide the background image on mobile
  • Use flexbox for the three column layout, turning it into three rows on thin windows

@samvasko
Copy link
Contributor

Would you be interested on working on making the site more responsive @JoshuaKGoldberg ?

@JoshuaKGoldberg
Copy link
Author

I would, if you're willing to wait a little while. I'm taken through the end of the summer...

@schaazzz
Copy link

schaazzz commented Mar 21, 2017

@JoshuaKGoldberg @samvasko
I'd be willing to put in some to time help make the site more responsive :)

  • Why not make life easy and just switch to Bootstrap? Easy to integrate and is responsive out of the box!

  • A terminal session GIF (recorded using, for example, Screen2GIF) can also be used to show commands being typed.

    • ...alternatively, a static image can be shown initially, which can be replaced after a few seconds with the GIF using JS.

@samvasko
Copy link
Contributor

samvasko commented Mar 21, 2017

@schaazzz It currently has a grid system and I think it just needs bit of tweaking for different viewports. And give a the gif a try! I am happy to add to to main project README as well. 👍

@MartiUK MartiUK self-assigned this Nov 20, 2017
@DRSDavidSoft
Copy link
Contributor

DRSDavidSoft commented Apr 21, 2018

@JoshuaKGoldberg I wrote a fix in #22 by replacing lemonade to the new bootstrap, which uses flexboxes.

I've also been working on a HTML+CSS recreation of the window, instead of the current jpeg file.

I currently have a working demo that you can have a look at in my rewrite branch here:
https://github.com/DRSDavidSoft/cmderdev.github.io/blob/gh-pages/.workspace/cmder-web.html

The discussion has been moved here: cmder-site/rewrite#15

I think this approach is better than simply embedding a gif file, as it won't look good on >100% dpi displays, takes a lot of useless disk-space space and bandwidth, and most importantly is not responsive. Instead, I've used jQuery Terminal to actually display a terminal with text.

I hope @samvasko approves! he doesn't seem to work on Cmder these days. I wonder if he's still on Windows, or switched to Linux/macOS.

Anyways, as @schaazzz suggests, we can use an image polyfill at first, and after the terminal window is created, replace it with that. But it won't be needed as these days everybody seems to have Javascript enabled. It's enabled by default on Android/iOS, Chrome & Edge on Windows.

I'd like to work on the website and make it look better and more intuitive for the user in summer, as well.

So, if @JoshuaKGoldberg and @schaazzz have time to work on the website (and they're still interested to), please collaborate on the rewrite branch instead of creating a new fork.

@Stanzilla
Copy link
Member

What would making sure of that entail exactly?

@DRSDavidSoft
Copy link
Contributor

DRSDavidSoft commented Apr 22, 2018

@Stanzilla I've explained it here: DRSDavidSoft#12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants