Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uniform pdfs for rateParam & flatParam nuisance parameters #819

Closed
nucleosynthesis opened this issue Feb 15, 2023 · 3 comments
Closed

uniform pdfs for rateParam & flatParam nuisance parameters #819

nucleosynthesis opened this issue Feb 15, 2023 · 3 comments

Comments

@nucleosynthesis
Copy link
Contributor

In most use cases, there is no need to include a pdf for rateParam / flatParam nuisances (in all fully frequentist methods, it makes no difference), however having the ability to include them could be useful in some cases eg

  • Bayesian methods in which the nuisance parameter (not just the POI) has a uniform prior
  • Cousins-Highland based toy generation where one or more nuisance parameter is assumed to have a flat pdf

It should be as simple as creating a user flag (even rtd) that tells combine to create a uniform pdf and include it into the NuisancePdf (along with some dummy global observable that effectively does nothing), but would also require some basic testing to make sure it doesn't break other things.

@nucleosynthesis
Copy link
Contributor Author

More thoughts on this ... it should be possible to use the fact that these nuisances if declared as such in the card, will have the attribute "flatParam". This could be used to check which additional Prior terms should be constructed during the text2workspace stages.

@anigamova
Copy link
Collaborator

It is unclear to me why do we need a global observable or what to do with it in this case. Obviously RooUniform does not have any parameters so we can not introduce a global observable to the function as it is done in RooGaussian for example.

@kcormi
Copy link
Collaborator

kcormi commented May 16, 2023

Addressed by #834

@kcormi kcormi closed this as completed May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants