Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Parameter Set #230

Closed
2 tasks
vdice opened this issue Aug 17, 2020 · 3 comments
Closed
2 tasks

Add Parameter Set #230

vdice opened this issue Aug 17, 2020 · 3 comments

Comments

@vdice
Copy link
Member

vdice commented Aug 17, 2020

Porter implemented Parameter Sets, a correlate for parameters to the Credential Set originally defined in the cnab-spec repo and its golang implementation existing here in this repo. This issue is therefore around migrating the re-usable Parameter Set definition(s) and methods into this library for the broader community to use.

@carolynvs
Copy link
Contributor

It seems to me that unless we change the schema for credentialsets to be generic, there will need to be two schema: one for each. So parameters' schemaVersion would be cnab-parametersets-1.0.0-DRAFT-* and credentials would be cnab-credentialsets-1.0.0-DRAFT-*.

I'm not sure consolidating them together and causing the breaking change for such little value is worth it.

@vdice
Copy link
Member Author

vdice commented Sep 1, 2020

I started on this but realized we'd want to get #229 in first. (Porter currently references code from the branch in 229, including some of the files intended for porting over to this library.)

@carolynvs
Copy link
Contributor

Closing since we've since changed direction about putting non-runtime concerns into cnab-go.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants