add PUPPETEER_DOWNLOAD_BASE_URL for puppeteer@20 #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
elrrrrrrr
commented
May 5, 2023
elrrrrrrr
commented
- 🆕 Added env config
- 🤖 Update mockAgent in test case
- 🆕 增加 env 配置
- 🤖 修改测试用例 mock 方法
elrrrrrrr
force-pushed
the
feat-add-puppeteer-new-env
branch
from
b12c2d5 to
dfaa064
Compare
Codecov Report
@@ Coverage Diff @@
## master #47 +/- ##
=======================================
Coverage 74.61% 74.61%
=======================================
Files 2 2
Lines 193 193
Branches 34 34
=======================================
Hits 144 144
Misses 49 49 |
elrrrrrrr
changed the title
|
PUPPETEER_DOWNLOAD_HOST=https://cdn.npmmirror.com/binaries/chrome-for-testing npminstall puppeteer@19 @elrrrrrrr 老的 PUPPETEER_DOWNLOAD_HOST 也改掉，已经兼容。 |
elrrrrrrr
force-pushed
the
feat-add-puppeteer-new-env
branch
from
dfaa064 to
1562846
Compare
fengmk2
reviewed
May 5, 2023
| @@ -58,7 +58,7 @@ | |||
| "SASS_BINARY_SITE": "https://cdn.npmmirror.com/binaries/node-sass", | |||
| "SWC_BINARY_SITE": "https://cdn.npmmirror.com/binaries/node-swc", | |||
| "NWJS_URLBASE": "https://cdn.npmmirror.com/binaries/nwjs/v", | |||
| "PUPPETEER_DOWNLOAD_HOST": "https://cdn.npmmirror.com/binaries", | |||
| "PUPPETEER_DOWNLOAD_HOST": "https://cdn.npmmirror.com/binaries/chrome-for-testing", | |||
There was a problem hiding this comment.
@elrrrrrrr PUPPETEER_DOWNLOAD_BASE_URL 也得加上，新版本不会使用 PUPPETEER_DOWNLOAD_HOST 了
elrrrrrrr
force-pushed
the
feat-add-puppeteer-new-env
branch
from
1562846 to
156b298
Compare
fengmk2
approved these changes
May 5, 2023
fengmk2
pushed a commit
that referenced
this pull request
May 5, 2023
[skip ci] ## [2.11.0](v2.10.0...v2.11.0) (2023-05-05) ### Features * add PUPPETEER_DOWNLOAD_BASE_URL for puppeteer@20 ([#47](#47)) ([dec350b](dec350b))
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.