Skip to content
This repository has been archived by the owner on Jun 2, 2024. It is now read-only.

feat: support semver #816

Merged
merged 4 commits into from
Feb 1, 2016
Merged

feat: support semver #816

merged 4 commits into from
Feb 1, 2016

Conversation

dead-horse
Copy link
Member

e.x. /npm/~1.0.0

closes #814

e.x. `/npm/~1.0.0`
@@ -73,6 +74,18 @@ exports.getModuleByTag = function* (name, tag) {
return yield* exports.getModule(tag.name, tag.version);
};

exports.getModuleByRange = function* (name, range) {
var rows = yield* exports.listModulesByName(name);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yield

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

到处都是 yield* ,先保留,后续找时间重构的时候全部替换掉吧

@fengmk2
Copy link
Member

fengmk2 commented Jan 30, 2016

pnpm need this feat
image

@fengmk2
Copy link
Member

fengmk2 commented Jan 30, 2016

@dead-horse ci fail

@@ -65,9 +65,9 @@ function routes(app) {

// module
// scope package: params: [$name]
app.get(/^\/(@[\w\-\.]+\/[\w\-\.]+)$/, syncByInstall, listAllVersions);
app.get(/^\/(@[\w\-\.]+\/[^\/]+)$/, syncByInstall, listAllVersions);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个不需要修改吧。

@fengmk2
Copy link
Member

fengmk2 commented Jan 30, 2016

@dead-horse
Copy link
Member Author

又有人上传了 tfs 导致 ci 挂了,我换了一个包,等它生效。。。

@fengmk2
Copy link
Member

fengmk2 commented Jan 31, 2016

mysql 挂了?

@codecov-io
Copy link

Current coverage is 82.43%

Merging #816 into master will decrease coverage by -0.21% as of 2f29e23

@@            master    #816   diff @@
======================================
  Files           84      84       
  Stmts         3227    3239    +12
  Branches       598     599     +1
  Methods          0       0       
======================================
+ Hit           2667    2670     +3
- Partial        202     211     +9
  Missed         358     358       

Review entire Coverage Diff as of 2f29e23

Powered by Codecov. Updated on successful CI builds.

@dead-horse
Copy link
Member Author

过了

@fengmk2
Copy link
Member

fengmk2 commented Feb 1, 2016

+1

fengmk2 added a commit that referenced this pull request Feb 1, 2016
@fengmk2 fengmk2 merged commit 3a46b97 into master Feb 1, 2016
@fengmk2 fengmk2 deleted the feat-semver branch February 1, 2016 03:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

支持 semver
3 participants