-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
功能:添加 gkd-mrlc (#301 ) #301
Conversation
WalkthroughThe pull request updates the Changes
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- package.json (1 hunks)
🧰 Additional context used
🪛 GitHub Check: Node.js / Test (ubuntu-latest, 20)
package.json
[failure] 7148-7148:
Expected object keys to be in ascending order. 'gkd-mrlc' should be before 'gunzip-maybe'
"gkd-mrlc": { | ||
"version": "*" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Package ordering needs adjustment
The newly added package "gkd-mrlc" is not in the correct alphabetical order. To maintain consistency and improve readability in this large package list, it should be moved to its proper alphabetical position.
Please move the "gkd-mrlc" entry to its correct alphabetical position, which should be before "glob". Here's the suggested change:
"glob": {
"version": "*"
},
+ "gkd-mrlc": {
+ "version": "*"
+ },
"glob-to-regexp": {
"version": "*"
},
- "gkd-mrlc": {
- "version": "*"
- },
"global": {
"version": "*"
},
This adjustment will ensure that the package list remains properly ordered, making it easier to maintain and search through in the future.
Committable suggestion was skipped due to low confidence.
🧰 Tools
🪛 GitHub Check: Node.js / Test (ubuntu-latest, 20)
[failure] 7148-7148:
Expected object keys to be in ascending order. 'gkd-mrlc' should be before 'gunzip-maybe'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (1)
- package.json (2 hunks)
🧰 Additional context used
🪛 GitHub Check: Node.js / Test (ubuntu-latest, 20)
package.json
[failure] 7151-7151:
Expected object keys to be in ascending order. 'gkd-mrlc' should be before 'gunzip-maybe'
[failure] 7151-7151:
Duplicate key 'gkd-mrlc'
"gkd-mrlc": { | ||
"version": "*" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove duplicate entry and correct alphabetical order
The package "gkd-mrlc" has been added twice in the dependencies list. Additionally, it's not in the correct alphabetical order in both locations. To fix this:
- Remove the duplicate entry (lines 7151-7153).
- Move the remaining entry to its correct alphabetical position, which should be before "glob".
Here's the suggested change:
"glob": {
"version": "*"
},
+ "gkd-mrlc": {
+ "version": "*"
+ },
"glob-to-regexp": {
"version": "*"
},
- "gkd-mrlc": {
- "version": "*"
- },
"global": {
"version": "*"
},
This change will resolve both the duplication issue and ensure proper alphabetical ordering of the dependencies.
Also applies to: 7151-7153
feat: add gkd-mrlc (cnpm#301)
Summary by CodeRabbit
New Features
gkd-mrlc
, enhancing project capabilities.Chores
unpkg-white-list
package version from1.134.0
to1.135.0
.