Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

功能：添加 gkd-mrlc （#301 ） #301

Closed
wants to merge 3 commits into from
Closed

功能：添加 gkd-mrlc （#301 ） #301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
54762b8
Update package.json
mrlctate Oct 19, 2024
8f2dd71
功能：添加 gkd-mrlc ( #301 )
mrlctate Oct 19, 2024
c7a8736
Merge branch 'master' of https://github.com/mrlctate/unpkg-white-list
mrlctate Oct 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6713,6 +6713,9 @@
"giturl": {
"version": "*"
},
"gkd-mrlc": {
"version": "*"
},
Comment on lines +6716 to +6718
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Remove duplicate entry and correct alphabetical order

The package "gkd-mrlc" has been added twice in the dependencies list. Additionally, it's not in the correct alphabetical order in both locations. To fix this:

  1. Remove the duplicate entry (lines 7151-7153).
  2. Move the remaining entry to its correct alphabetical position, which should be before "glob".

Here's the suggested change:

    "glob": {
      "version": "*"
    },
+   "gkd-mrlc": {
+     "version": "*"
+   },
    "glob-to-regexp": {
      "version": "*"
    },
-   "gkd-mrlc": {
-     "version": "*"
-   },
    "global": {
      "version": "*"
    },

This change will resolve both the duplication issue and ensure proper alphabetical ordering of the dependencies.

Also applies to: 7151-7153

"gkd-subscription": {
"version": "*"
},
Expand Down Expand Up @@ -7145,6 +7148,9 @@
"gunzip-maybe": {
"version": "*"
},
"gkd-mrlc": {

Check failure on line 7151 in package.json

View workflow job for this annotation

GitHub Actions / Node.js / Test (ubuntu-latest, 20) 

Expected object keys to be in ascending order. 'gkd-mrlc' should be before 'gunzip-maybe'

Check failure on line 7151 in package.json

View workflow job for this annotation

GitHub Actions / Node.js / Test (ubuntu-latest, 20) 

Duplicate key 'gkd-mrlc'

Check failure on line 7151 in package.json

View workflow job for this annotation

GitHub Actions / Node.js / Test (ubuntu-latest, 20) 

Expected object keys to be in ascending order. 'gkd-mrlc' should be before 'gunzip-maybe'

Check failure on line 7151 in package.json

View workflow job for this annotation

GitHub Actions / Node.js / Test (ubuntu-latest, 20) 

Duplicate key 'gkd-mrlc'
"version": "*"
},
Comment on lines +7151 to +7153
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Package ordering needs adjustment

The newly added package "gkd-mrlc" is not in the correct alphabetical order. To maintain consistency and improve readability in this large package list, it should be moved to its proper alphabetical position.

Please move the "gkd-mrlc" entry to its correct alphabetical position, which should be before "glob". Here's the suggested change:

    "glob": {
      "version": "*"
    },
+   "gkd-mrlc": {
+     "version": "*"
+   },
    "glob-to-regexp": {
      "version": "*"
    },
-   "gkd-mrlc": {
-     "version": "*"
-   },
    "global": {
      "version": "*"
    },

This adjustment will ensure that the package list remains properly ordered, making it easier to maintain and search through in the future.

Committable suggestion was skipped due to low confidence.

🧰 Tools
🪛 GitHub Check: Node.js / Test (ubuntu-latest, 20)

[failure] 7148-7148:
Expected object keys to be in ascending order. 'gkd-mrlc' should be before 'gunzip-maybe'

"gzip-size": {
"version": "*"
},
Expand Down
Loading
Loading