Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes all instances of uppercase c to lowercase #35

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Changes all instances of uppercase c to lowercase #35

wants to merge 2 commits into from

Conversation

tacocats
Copy link

@tacocats tacocats commented Apr 1, 2017

No description provided.

@iakat
Copy link
Member

iakat commented Apr 2, 2017

Renamed uppercase C coala files -> Rename `Coala` to `coala` in file names
also, typo in the commit body

@tacocats
Copy link
Author

tacocats commented Apr 2, 2017

@chauffer Updated it to use that message for commit and fixed the typo.

@RohanVB
Copy link
Member

RohanVB commented Apr 2, 2017

You already had a PR opened addressing the same issue :/
I made some comments on that, you haven't addressed them here either.
Please check it out: #34 :D

@tacocats
Copy link
Author

tacocats commented Apr 2, 2017

@RohanVB I looked it over but accidentally closed it when I re-forked the repo. I looked over the guidelines, but was unable to find anymore instances of Coala in the files. Sorry for not replying to it, wasn't sure what happened with it when it closed.

@RohanVB
Copy link
Member

RohanVB commented Apr 3, 2017

anymore instances of Coala in the files.

Have you tried running 'coalaBear' on your project?

@RohanVB
Copy link
Member

RohanVB commented Apr 3, 2017

Also, you'll have to rebase and squash the extra commits.

@tacocats
Copy link
Author

tacocats commented Apr 3, 2017

@RohanVB I ran coalaBear, is this what is wanted? https://github.com/tacocats/coala-sublime/commit/effa7c9449224f55472a6c6731be6569f112d1bc
I was originally leaving the COALA_KEY as is, I changed it to cOALA_KEY, it looks sorta wierd though, should I make it coala_KEY?
Also squashed the commits.

@RohanVB
Copy link
Member

RohanVB commented Apr 4, 2017

Yeah. coala_KEY/coala_key looks better.

@RohanVB
Copy link
Member

RohanVB commented Apr 4, 2017

Also in commit body of https://github.com/tacocats/coala-sublime/commit/292abe4f2cd1d4f54c980251364734639c1d8199, there's a typo. Uppercase. Everything else looks good right now.

@tacocats
Copy link
Author

tacocats commented Apr 6, 2017

@RohanVB rebased and fixed all instances with coala. Sorry this took so long, have been really busy recently.

@RohanVB
Copy link
Member

RohanVB commented Apr 6, 2017

commit issue ref: Fixes ->Closes since it's not a bug.

jack added 2 commits April 6, 2017 13:15
This renames all the files that start with an upercase C for coala, making them use a lowercase c.

Closes #30
This replaces all instances of 'Coala' (an uppercase C) in all the files with 'coala' (a lower case c).

Closes #30
@tacocats
Copy link
Author

tacocats commented Apr 6, 2017

Changed Fixes to Closes.

@RohanVB
Copy link
Member

RohanVB commented Apr 6, 2017

ack 9aee62b

@RohanVB
Copy link
Member

RohanVB commented Apr 6, 2017

ack 4c3e67a

@@ -8,11 +8,11 @@
from contextlib import contextmanager, closing


COALA_KEY = "coala-sublime"
coala_key = "coala-sublime"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nooooo ... CONSTANTS should always be capitalised. That is PEP 8.

I suggest giving this constant a different name. APP_NAME ?

@jayvdb
Copy link
Member

jayvdb commented Apr 28, 2017

unack 4c3e67a 9aee62b

@jayvdb
Copy link
Member

jayvdb commented Apr 28, 2017

Also , as you are naming files, please switch them to using snake_case

@jayvdb
Copy link
Member

jayvdb commented May 3, 2018

ping @tacocats

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants