-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes all instances of uppercase c to lowercase #35
base: master
Are you sure you want to change the base?
Conversation
|
@chauffer Updated it to use that message for commit and fixed the typo. |
You already had a PR opened addressing the same issue :/ |
@RohanVB I looked it over but accidentally closed it when I re-forked the repo. I looked over the guidelines, but was unable to find anymore instances of Coala in the files. Sorry for not replying to it, wasn't sure what happened with it when it closed. |
Have you tried running 'coalaBear' on your project? |
Also, you'll have to rebase and squash the extra commits. |
@RohanVB I ran coalaBear, is this what is wanted? https://github.com/tacocats/coala-sublime/commit/effa7c9449224f55472a6c6731be6569f112d1bc |
Yeah. coala_KEY/coala_key looks better. |
Also in commit body of https://github.com/tacocats/coala-sublime/commit/292abe4f2cd1d4f54c980251364734639c1d8199, there's a typo. Uppercase. Everything else looks good right now. |
@RohanVB rebased and fixed all instances with coala. Sorry this took so long, have been really busy recently. |
commit issue ref: |
Changed Fixes to Closes. |
ack 9aee62b |
ack 4c3e67a |
@@ -8,11 +8,11 @@ | |||
from contextlib import contextmanager, closing | |||
|
|||
|
|||
COALA_KEY = "coala-sublime" | |||
coala_key = "coala-sublime" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nooooo ... CONSTANTS should always be capitalised. That is PEP 8.
I suggest giving this constant a different name. APP_NAME
?
Also , as you are naming files, please switch them to using snake_case |
ping @tacocats |
No description provided.