Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Allow setting monaco editor's quickSuggestions argument #182

Closed
egenn opened this issue Apr 5, 2024 · 1 comment
Closed

[Feature]: Allow setting monaco editor's quickSuggestions argument #182

egenn opened this issue Apr 5, 2024 · 1 comment
Labels
t: feature-request Request the addition of a new feature

Comments

@egenn
Copy link
Contributor

egenn commented Apr 5, 2024

Feature Description

Thank you for the awesome extension.

It would be great to allow setting monaco editor's quickSuggestions argument, e.g. by adding
quickSuggestions: qwebrOptions['quick-suggestions'] ?? true where editor is created in qwebr-monaco-editor-element.js.
I've tried this successfully, happy to open PR.
I use it for developing exercises, where suggestions can be distracting.
@egenn egenn added the t: feature-request Request the addition of a new feature label Apr 5, 2024
@egenn egenn changed the title [Feature]: Allow setting monaco editor's 'quickSuggestions' argument [Feature]: Allow setting monaco editor's quickSuggestions argument Apr 5, 2024
@coatless
Copy link
Owner

coatless commented Apr 5, 2024

@egenn sure! Let's go with an option of editor-quick-suggestions: false. Sound okay?

PRs are welcome or I can patch it in as it'll be quick (~2 hours till back at a computer). Up to you.

@egenn egenn mentioned this issue Apr 5, 2024
Merged
@coatless coatless closed this as completed Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
t: feature-request Request the addition of a new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@coatless @egenn