Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Cell Spaces Are Not Preserved #39

Closed
coatless opened this issue Sep 22, 2023 · 0 comments
Closed

Code Cell Spaces Are Not Preserved #39

coatless opened this issue Sep 22, 2023 · 0 comments
Labels
p: high Address issue at next possible opening s: confirmed Issue was confirmed to exist t: bug Something isn't working
Milestone
0.3.x

Comments

@coatless
Copy link
Owner

Bug

When we introduced the code cell option context in v0.3.5, we lost space preservation in the initialized code.

Missing code cell spaces v0.3.5 Preserved code cell space v0.3.5

Possible fix

We should broaden the regular expression used to iterate through the multi-line text string:

quarto-webr/_extensions/webr/webr.lua

Line 374 in c4c2d83

for line in code:gmatch("[^\r\n]+") do

We also probably should think about removing the space immediately after the code cell option to be in parity with upstream Quarto.
@coatless coatless added the t: bug Something isn't working label Sep 22, 2023
@coatless coatless mentioned this issue Sep 22, 2023
Merged
@coatless coatless modified the milestones: 4.x, 0.3.x Nov 17, 2023
@coatless coatless added p: high Address issue at next possible opening s: confirmed Issue was confirmed to exist labels Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: high Address issue at next possible opening s: confirmed Issue was confirmed to exist t: bug Something isn't working
Projects
None yet
Milestone
0.3.x
Development

No branches or pull requests
1 participant
@coatless