Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add flag to throw on cyclic dependencies between named types #101

Merged
merged 2 commits into from
May 31, 2021

Conversation

runeh
Copy link
Collaborator

@runeh runeh commented May 29, 2021

I'm working on code to emit lazy runtypes when there are cyclical dependencies between them. This introduces a lot of the utility functions needed for that.

The new flag should be non-breaking, as the behaviour is unchanged if it's not set.

@runeh runeh requested a review from simenandre May 29, 2021 12:29
@codecov-commenter
Copy link

Codecov Report

Merging #101 (0a259e5) into main (1dba38f) will increase coverage by 20.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             main      #101       +/-   ##
============================================
+ Coverage   80.00%   100.00%   +20.00%     
============================================
  Files           2         2               
  Lines          35       181      +146     
  Branches        7        37       +30     
============================================
+ Hits           28       181      +153     
+ Misses          7         0        -7     
Impacted Files Coverage Δ
src/main.ts 100.00% <100.00%> (+22.58%) ⬆️
src/util.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a647c07...0a259e5. Read the comment docs.

Copy link
Owner

@simenandre simenandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this! This is just awesome!

@runeh runeh merged commit 2e33303 into main May 31, 2021
@runeh runeh deleted the cyclic-dependency-detection branch May 31, 2021 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants