Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add flag to detect unknown named types #106

Merged
merged 1 commit into from
Jun 1, 2021

Conversation

runeh
Copy link
Collaborator

@runeh runeh commented Jun 1, 2021

Adds a rejectUnknownNamedTypes option. If true, the generator throws if it encounters a named type that's not one of the root types.

The default value is false, so this shouldn't break anything.

@runeh runeh requested a review from simenandre June 1, 2021 07:38
@codecov-commenter
Copy link

Codecov Report

Merging #106 (f13000e) into main (1dba38f) will increase coverage by 20.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             main      #106       +/-   ##
============================================
+ Coverage   80.00%   100.00%   +20.00%     
============================================
  Files           2         2               
  Lines          35       185      +150     
  Branches        7        37       +30     
============================================
+ Hits           28       185      +157     
+ Misses          7         0        -7     
Impacted Files Coverage Δ
src/main.ts 100.00% <100.00%> (+22.58%) ⬆️
src/util.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e33303...f13000e. Read the comment docs.

Copy link
Owner

@simenandre simenandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🙏

@runeh runeh merged commit 85267f0 into main Jun 1, 2021
@runeh runeh deleted the reject-unknown-named-types-option branch June 1, 2021 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants