Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use formatter function for all named types #52

Merged
merged 1 commit into from
Apr 23, 2021

Conversation

runeh
Copy link
Collaborator

@runeh runeh commented Apr 22, 2021

I'd forgotten to use the formatRuntypeName everywhere, so the unformatted name was used some places, and that one didn't exist.

So we'd generate code like

const tagsRuntype = rt.Array(rt.string);

const post = rt.Record({title: rt.string, tags: tags}); // <- `tags` is wrong

I've propagated the settings object to all the formatters. We might need more settings in them in the future.

@runeh runeh merged commit 335fc0e into main Apr 23, 2021
@runeh runeh deleted the use-name-formatter-everywhere branch April 23, 2021 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants