Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.json: Pin down eslint-plugin-react to avoid 7.14.0 #12136

Merged

Conversation

martinpitt
Copy link
Member

7.14.0 has a grave bug which breaks our build:
jsx-eslint/eslint-plugin-react#2319

Until the fix is released, pin down to the previous version.

7.14.0 has a grave bug which breaks our build:
jsx-eslint/eslint-plugin-react#2319

Until the fix is released, pin down to the previous version.
@martinpitt martinpitt added no-test For doc/workflow changes, or experiments which don't need a full CI run, release-blocker Targetted for next release labels Jun 24, 2019
@martinpitt
Copy link
Member Author

This is the version that we had used until last night, so only triggering one test. This should land ASAP as it blocks literally everything now.

Copy link
Member

@marusak marusak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinpitt martinpitt merged commit 25063a8 into cockpit-project:master Jun 24, 2019
@martinpitt martinpitt deleted the fix-eslint-plugin-react branch June 24, 2019 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-test For doc/workflow changes, or experiments which don't need a full CI run, release-blocker Targetted for next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants