-
Notifications
You must be signed in to change notification settings - Fork 3.8k
/
Copy pathrename_database.go
276 lines (252 loc) · 8.24 KB
/
rename_database.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
// Copyright 2017 The Cockroach Authors.
//
// Use of this software is governed by the Business Source License
// included in the file licenses/BSL.txt.
//
// As of the Change Date specified in that file, in accordance with
// the Business Source License, use of this software will be governed
// by the Apache License, Version 2.0, included in the file
// licenses/APL.txt.
package sql
import (
"context"
"fmt"
"github.com/cockroachdb/cockroach/pkg/sql/parser"
"github.com/cockroachdb/cockroach/pkg/sql/pgwire/pgerror"
"github.com/cockroachdb/cockroach/pkg/sql/privilege"
"github.com/cockroachdb/cockroach/pkg/sql/sem/tree"
"github.com/cockroachdb/cockroach/pkg/sql/sqlbase"
"github.com/cockroachdb/cockroach/pkg/util"
"github.com/cockroachdb/cockroach/pkg/util/log"
"github.com/cockroachdb/errors"
)
type renameDatabaseNode struct {
dbDesc *sqlbase.DatabaseDescriptor
newName string
}
// RenameDatabase renames the database.
// Privileges: superuser, DROP on source database.
// Notes: postgres requires superuser, db owner, or "CREATEDB".
// mysql >= 5.1.23 does not allow database renames.
func (p *planner) RenameDatabase(ctx context.Context, n *tree.RenameDatabase) (planNode, error) {
if n.Name == "" || n.NewName == "" {
return nil, errEmptyDatabaseName
}
if string(n.Name) == p.SessionData().Database && p.SessionData().SafeUpdates {
return nil, pgerror.DangerousStatementf("RENAME DATABASE on current database")
}
if err := p.RequireAdminRole(ctx, "ALTER DATABASE ... RENAME"); err != nil {
return nil, err
}
dbDesc, err := p.ResolveUncachedDatabaseByName(ctx, string(n.Name), true /*required*/)
if err != nil {
return nil, err
}
if err := p.CheckPrivilege(ctx, dbDesc, privilege.DROP); err != nil {
return nil, err
}
if n.Name == n.NewName {
// Noop.
return newZeroNode(nil /* columns */), nil
}
return &renameDatabaseNode{
dbDesc: dbDesc,
newName: string(n.NewName),
}, nil
}
// ReadingOwnWrites implements the planNodeReadingOwnWrites interface.
// This is because RENAME DATABASE performs multiple KV operations on descriptors
// and expects to see its own writes.
func (n *renameDatabaseNode) ReadingOwnWrites() {}
func (n *renameDatabaseNode) startExec(params runParams) error {
p := params.p
ctx := params.ctx
dbDesc := n.dbDesc
// Check if any other tables depend on tables in the database.
// Because our views and sequence defaults are currently just stored as
// strings, they (may) explicitly specify the database name.
// Rather than trying to rewrite them with the changed DB name, we
// simply disallow such renames for now.
// See #34416.
phyAccessor := p.PhysicalSchemaAccessor()
lookupFlags := p.CommonLookupFlags(true /*required*/)
// DDL statements bypass the cache.
lookupFlags.AvoidCached = true
schemas, err := p.Tables().getSchemasForDatabase(ctx, p.txn, dbDesc.ID)
if err != nil {
return err
}
for _, schema := range schemas {
tbNames, err := phyAccessor.GetObjectNames(
ctx,
p.txn,
dbDesc,
schema,
tree.DatabaseListFlags{
CommonLookupFlags: lookupFlags,
ExplicitPrefix: true,
},
)
if err != nil {
return err
}
lookupFlags.Required = false
for i := range tbNames {
objDesc, err := phyAccessor.GetObjectDesc(ctx, p.txn, p.ExecCfg().Settings,
&tbNames[i], tree.ObjectLookupFlags{CommonLookupFlags: lookupFlags})
if err != nil {
return err
}
if objDesc == nil {
continue
}
tbDesc := objDesc.TableDesc()
for _, dependedOn := range tbDesc.DependedOnBy {
dependentDesc, err := sqlbase.GetTableDescFromID(ctx, p.txn, dependedOn.ID)
if err != nil {
return err
}
isAllowed, missingCol, err := isAllowedDependentDescInRenameDatabase(
dependedOn,
tbDesc,
dependentDesc,
dbDesc.Name,
)
if err != nil {
return err
}
if isAllowed {
continue
}
tbTableName := tree.MakeTableNameWithSchema(
tree.Name(dbDesc.Name),
tree.Name(schema),
tree.Name(tbDesc.Name),
)
var dependentDescQualifiedString string
if dbDesc.ID != dependentDesc.ParentID || tbDesc.GetParentSchemaID() != dependentDesc.GetParentSchemaID() {
var err error
dependentDescQualifiedString, err = p.getQualifiedTableName(ctx, dependentDesc)
if err != nil {
log.Warningf(
ctx,
"unable to retrieve fully-qualified name of %s (id: %d): %v",
tbTableName.String(),
dependentDesc.ID,
err,
)
msg := fmt.Sprintf(
"cannot rename database because a relation depends on relation %q",
tbTableName.String(),
)
return sqlbase.NewDependentObjectError(msg)
}
} else {
dependentDescTableName := tree.MakeTableNameWithSchema(
tree.Name(dbDesc.Name),
tree.Name(schema),
tree.Name(dependentDesc.Name),
)
dependentDescQualifiedString = dependentDescTableName.String()
}
msg := fmt.Sprintf(
"cannot rename database because relation %q depends on relation %q",
dependentDescQualifiedString,
tbTableName.String(),
)
// We can have a more specific error message for sequences.
if tbDesc.IsSequence() {
hint := fmt.Sprintf(
"you can drop the column default %q of %q referencing %q",
missingCol,
tbTableName.String(),
dependentDescQualifiedString,
)
if dependentDesc.GetParentID() == dbDesc.ID {
hint += fmt.Sprintf(
" or modify the default to not reference the database name %q",
dbDesc.Name,
)
}
return sqlbase.NewDependentObjectErrorWithHint(msg, hint)
}
// Otherwise, we default to the view error message.
hint := fmt.Sprintf("you can drop %q instead", dependentDescQualifiedString)
return sqlbase.NewDependentObjectErrorWithHint(msg, hint)
}
}
}
return p.renameDatabase(ctx, dbDesc, n.newName)
}
// isAllowedDependentDescInRename determines rename database is allowed when
// a given {tbDesc, dependentDesc} with the relationship dependedOn on a db named dbName.
// Returns a bool representing whether it's allowed, a string indicating the column name
// it could not found, and an error if there is any.
// This is a workaround for #45411 until #34416 is resolved.
func isAllowedDependentDescInRenameDatabase(
dependedOn sqlbase.TableDescriptor_Reference,
tbDesc *sqlbase.TableDescriptor,
dependentDesc *sqlbase.TableDescriptor,
dbName string,
) (bool, string, error) {
// If it is a sequence, and it does not contain the database name, then we have
// no reason to block it's deletion.
if !tbDesc.IsSequence() {
return false, "", nil
}
colIDs := util.MakeFastIntSet()
for _, colID := range dependedOn.ColumnIDs {
colIDs.Add(int(colID))
}
for _, column := range dependentDesc.Columns {
if !colIDs.Contains(int(column.ID)) {
continue
}
colIDs.Remove(int(column.ID))
if column.DefaultExpr == nil {
return false, "", errors.AssertionFailedf(
"rename_database: expected column id %d in table id %d to have a default expr",
dependedOn.ID,
dependentDesc.ID,
)
}
// Try parse the default expression and find the table name direct reference.
parsedExpr, err := parser.ParseExpr(*column.DefaultExpr)
if err != nil {
return false, "", err
}
typedExpr, err := tree.TypeCheck(parsedExpr, nil, &column.Type)
if err != nil {
return false, "", err
}
seqNames, err := getUsedSequenceNames(typedExpr)
if err != nil {
return false, "", err
}
for _, seqName := range seqNames {
parsedSeqName, err := parser.ParseTableName(seqName)
if err != nil {
return false, "", err
}
// There must be at least two parts for this to work.
if parsedSeqName.NumParts >= 2 {
// We only don't allow this if the database name is in there.
// This is always the last argument.
if tree.Name(parsedSeqName.Parts[parsedSeqName.NumParts-1]).Normalize() == tree.Name(dbName).Normalize() {
return false, column.Name, nil
}
}
}
}
if colIDs.Len() > 0 {
return false, "", errors.AssertionFailedf(
"expected to find column ids %s in table id %d",
colIDs.String(),
dependentDesc.ID,
)
}
return true, "", nil
}
func (n *renameDatabaseNode) Next(runParams) (bool, error) { return false, nil }
func (n *renameDatabaseNode) Values() tree.Datums { return tree.Datums{} }
func (n *renameDatabaseNode) Close(context.Context) {}