-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
104641: cli/doctor: address issues in the debug doctor command r=fqazi a=fqazi Previously, the debug doctor had the following issues on master: 1. Running the 23.1 / master doctor against older cluster versions would run into issues with the jobs tables since we started using a new crdb_internal table to get a similar view 2. Quoted table names in a zip directory were not unescaped properly, which could lead to validation errors 3. Added support for JSON based zipdirs which are the default on master 104803: backupccl: break dependency on gossip r=yuzefovich a=yuzefovich This commit removes the dependency of the backup / restore on gossip. Previously, gossip was used to count the number of nodes in the cluster, and this information is used for telemetry reporting as well as for chunking up the working spans. However, that seems unnecessary and in some cases incorrect. In particular, for backup telemetry we computed speed per node via dividing by the cluster node count, but we might have used less SQL instances, so we should actually be dividing by the number of SQL instances used in the backup plan. In restore we use all available SQL instances, and we now calculate that number right before using it for telemetry calculation. It's possible that we used different number of instances in the restore operations (which there appear to be three) when the instances went up or down, but it's probably not that important. Addresses: #54252. Epic: None. Release note: None 104809: sql/pgwire: deflake TestAuthenticationAndHBARules r=rafiss a=andyyang890 This patch deflakes pgwire.TestAuthenticationAndHBARules by adding more `authlog` directives. Without an `authlog` after each connection attempt, there is non-determinism in the ordering of the logs. Fixes #104381 Fixes #100353 Release note: None Co-authored-by: Faizan Qazi <faizan@cockroachlabs.com> Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com> Co-authored-by: Andy Yang <yang@cockroachlabs.com>
- Loading branch information
Showing
18 changed files
with
777 additions
and
150 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.