From dfbabdc2fc97f6724cb59b36abe0d9366a843177 Mon Sep 17 00:00:00 2001 From: Oleg Afanasyev Date: Thu, 14 Sep 2023 18:49:01 +0100 Subject: [PATCH] rangefeed: metamorphic test option for rangefeed scheduler This commit adds metamorphic test option for rangefeed scheduler. It will randomly enable rangefeed scheduler. Default option is off. Epic: none Release note: None --- pkg/kv/kvserver/replica_rangefeed.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/kv/kvserver/replica_rangefeed.go b/pkg/kv/kvserver/replica_rangefeed.go index 2fc58d9dbaba..4e2b67834ed0 100644 --- a/pkg/kv/kvserver/replica_rangefeed.go +++ b/pkg/kv/kvserver/replica_rangefeed.go @@ -28,6 +28,7 @@ import ( "github.com/cockroachdb/cockroach/pkg/settings" "github.com/cockroachdb/cockroach/pkg/storage" "github.com/cockroachdb/cockroach/pkg/storage/enginepb" + "github.com/cockroachdb/cockroach/pkg/util" "github.com/cockroachdb/cockroach/pkg/util/admission" "github.com/cockroachdb/cockroach/pkg/util/admission/admissionpb" "github.com/cockroachdb/cockroach/pkg/util/envutil" @@ -79,14 +80,13 @@ var RangeFeedSmearInterval = settings.RegisterDurationSetting( // RangeFeedUseScheduler controls type of rangefeed processor is used to process // raft updates and sends updates to clients. -// TODO(oleg): add metamorphic variable for processor type selection. var RangeFeedUseScheduler = settings.RegisterBoolSetting( settings.SystemOnly, "kv.rangefeed.scheduler.enabled", "use shared fixed pool of workers for all range feeds instead of a "+ "worker per range (worker pool size is determined by "+ "COCKROACH_RANGEFEED_SCHEDULER_WORKERS env variable)", - false, + util.ConstantWithMetamorphicTestBool("kv_rangefeed_scheduler_enabled", false), ) func init() {