-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
77260: types: remove no longer used version gate r=yuzefovich a=yuzefovich This is done to break the dependency of `sql/types` on `roachpb` (which is a part of the effort to clean up the dependencies of `execgen`). This commit brings the dependencies of `execgen` to a much more reasonable set. Although there is an ask in place to not remove this code even if it's not used at the moment (so that we have the necessary infra in place if/when the need arises), in order to keep the functionality we would need to pull out `roachpb.Version` out of `roachpb`, and I don't want to embark on that since we're in stability period. Fixes: #77234. Release note: None Release justification: low risk change to clean up the dependencies. Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>
- Loading branch information
Showing
12 changed files
with
70 additions
and
131 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
// Copyright 2022 The Cockroach Authors. | ||
// | ||
// Use of this software is governed by the Business Source License | ||
// included in the file licenses/BSL.txt. | ||
// | ||
// As of the Change Date specified in that file, in accordance with | ||
// the Business Source License, use of this software will be governed | ||
// by the Apache License, Version 2.0, included in the file | ||
// licenses/APL.txt. | ||
|
||
package main | ||
|
||
import ( | ||
"testing" | ||
|
||
"github.com/cockroachdb/cockroach/pkg/testutils/buildutil" | ||
) | ||
|
||
func TestNoLinkForbidden(t *testing.T) { | ||
buildutil.VerifyNoImports(t, | ||
"github.com/cockroachdb/cockroach/pkg/sql/colexec/execgen/cmd/execgen", true, | ||
[]string{ | ||
"github.com/cockroachdb/cockroach/pkg/roachpb", | ||
"github.com/cockroachdb/cockroach/pkg/sql/catalog", | ||
"github.com/cockroachdb/cockroach/pkg/sql/execinfrapb", | ||
"github.com/cockroachdb/cockroach/pkg/sql/tree", | ||
}, nil, | ||
) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
// Copyright 2022 The Cockroach Authors. | ||
// | ||
// Use of this software is governed by the Business Source License | ||
// included in the file licenses/BSL.txt. | ||
// | ||
// As of the Change Date specified in that file, in accordance with | ||
// the Business Source License, use of this software will be governed | ||
// by the Apache License, Version 2.0, included in the file | ||
// licenses/APL.txt. | ||
|
||
package types | ||
|
||
import ( | ||
"testing" | ||
|
||
"github.com/cockroachdb/cockroach/pkg/testutils/buildutil" | ||
) | ||
|
||
func TestNoLinkForbidden(t *testing.T) { | ||
buildutil.VerifyNoImports(t, | ||
"github.com/cockroachdb/cockroach/pkg/sql/types", true, | ||
[]string{ | ||
"github.com/cockroachdb/cockroach/pkg/clusterversion", | ||
"github.com/cockroachdb/cockroach/pkg/roachpb", | ||
}, nil, | ||
) | ||
} |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.