From 3255968e1ed166667d90eed1714f943067c6f92c Mon Sep 17 00:00:00 2001 From: David Taylor Date: Mon, 30 Sep 2019 13:15:04 +0000 Subject: [PATCH] storage: fix incorrect listener on concurrent AddSST setting Copy/paste mistake meant that the wrong setting was being used to trigger the re-read of the setting on-update. Release note (bug fix): fix bug that prevented changes to kv.bulk_io_write.concurrent_addsstable_requests from taking effect. Release justification: very small, low-risk fix for user-visible bug in existing code. --- pkg/storage/store.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/storage/store.go b/pkg/storage/store.go index e36503ad2090..24eaee88998f 100644 --- a/pkg/storage/store.go +++ b/pkg/storage/store.go @@ -897,7 +897,7 @@ func NewStore( s.limiters.ConcurrentAddSSTableRequests = limit.MakeConcurrentRequestLimiter( "addSSTableRequestLimiter", int(addSSTableRequestLimit.Get(&cfg.Settings.SV)), ) - importRequestsLimit.SetOnChange(&cfg.Settings.SV, func() { + addSSTableRequestLimit.SetOnChange(&cfg.Settings.SV, func() { s.limiters.ConcurrentAddSSTableRequests.SetLimit(int(addSSTableRequestLimit.Get(&cfg.Settings.SV))) }) s.limiters.ConcurrentRangefeedIters = limit.MakeConcurrentRequestLimiter(